fix(schema-editor): can Change refSchema and Select refTable in Schema Editor. closes #3581 #4635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dtroelofsprins
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Functional review:
- Already existing refSchema, refTable combinations are now shown properly
- Can select refTable from popup list if refSchema is selected in Schema Editor for a new column (even shows only ref and not ontology tables in case of datatype = ref and vice versa if dataType = ontology).
- Get a warning if dataType = ontology and current schema contains no ontologies, so a refSchema with ontologies needs to be selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #3581