Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add .vscode/ to .gitignore #4640

Merged
merged 2 commits into from
Jan 27, 2025
Merged

chore: Add .vscode/ to .gitignore #4640

merged 2 commits into from
Jan 27, 2025

Conversation

hslh
Copy link
Contributor

@hslh hslh commented Jan 27, 2025

.vscode is the folder for Visual Studio Code editor-related files, it probably shouldn't be included in the repository.

.vscode is the folder for Visual Studio Code editor-related files
@hslh hslh added the chore A task that improves the code but doesn't add new functionality label Jan 27, 2025
@hslh hslh changed the title Add .vscode/ to .gitignore chore: Add .vscode/ to .gitignore Jan 27, 2025
@hslh hslh marked this pull request as ready for review January 27, 2025 10:59
@hslh hslh requested a review from davidruvolo51 January 27, 2025 10:59
@hslh
Copy link
Contributor Author

hslh commented Jan 27, 2025

@davidruvolo51 I've asked you for review because the existing .vscode directory originates from one of your commits

Copy link
Contributor

@davidruvolo51 davidruvolo51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Yes, it is something that shouldn't be in the repository.

@hslh hslh merged commit 40b8054 into master Jan 27, 2025
7 checks passed
@hslh hslh deleted the chore-vscode-gitignore branch January 27, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task that improves the code but doesn't add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants