Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(rdf): included custom_rdf advanced setting #4641

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Conversation

svandenhoek
Copy link
Contributor

What are the main changes you did

  • Added docs to explain custom_rdf advanced setting

How to test

  • check if docs correct?

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

**The value of the `custom_rdf` advanced setting requires valid Turtle-formatted RDF!**

When this advanced setting is set, it will result in the following:
* The default namespaces will be ignored (except for the schema-specific namespace which is always present).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you not want to override the default namespace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably depends on how big the default list is. For example, if it includes a lot of namespaces not relevant for that schema you might want to be able to exclude namespaces as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative is building in a check where we exclude unused namespaces (maybe this might be a very easy toggle in RDF4J?). Either way, I think the bigger question is if we want to rely on this at all or move to schema-specific namespaces where the default list only functions as a "fallback".

If it's only a fallback, this approach would suffice I think. If we want to "build upon a hardcoded default list" within each schema instead, then indeed we should change this behaviour.

@svandenhoek svandenhoek merged commit ef3db09 into master Jan 27, 2025
7 checks passed
@svandenhoek svandenhoek deleted the docs/custom_rdf branch January 27, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants