Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: changes to form stories #4648

Merged
merged 2 commits into from
Jan 29, 2025
Merged

revert: changes to form stories #4648

merged 2 commits into from
Jan 29, 2025

Conversation

mswertz
Copy link
Member

@mswertz mswertz commented Jan 29, 2025

What are the main changes you did

  • explain what you changed and essential considerations.

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@mswertz mswertz requested a review from davidruvolo51 January 29, 2025 09:57
Copy link
Contributor

@connoratrug connoratrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiple issues remain and test are still missing

  • console log statements
  • inconsistent styling
  • input is not tested in the form context

@connoratrug connoratrug merged commit 668a564 into master Jan 29, 2025
6 of 7 checks passed
@connoratrug connoratrug deleted the fix/tw_form_loading branch January 29, 2025 10:09
@mswertz
Copy link
Member Author

mswertz commented Jan 29, 2025

multiple issues remain and test are still missing

  • console log statements
  • inconsistent styling
  • input is not tested in the form context

sure. In this phase I consider the tailwind components alpha and it should actually be behind a feature switch.

@connoratrug
Copy link
Contributor

the components lib is used by the catalogue app, the catalogue app in not alpha, catalogue app is part of the emx2 mono repo, the emx2 service is not in alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants