memory leak fix (by argon) and another 'upstream is not defined' check #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simllll Are you still using this in production? Looking at just hosting a zip and referencing from my own package. Can't believe no movement here... |
|
Hey Andrew,yes still using it. True that,not sure what happened to the repo owner?! |
|
hope merge as soon as possible |
This was referenced Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR contains Clean up ended streams to free leaked memory #200 and an additional check if stream is defined. (line 314)
without these changes I was not able to run this code for a longer time. I use this in production, should be well "tested".