Alert only the string #551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscheffauer
reviewed
Jul 30, 2024
|
|
||
| // check if toast got removed and the toast is not active anymore | ||
| await waitForElementToBeRemoved(() => screen.queryByRole('alert')); | ||
| await waitForElementToBeRemoved(screen.getByText(textContent)); |
There was a problem hiding this comment.
this always need to be queryByRole, otherwise its not working correctly, see here:
https://testing-library.com/docs/guide-disappearance/#waiting-for-disappearance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only the text part of the notification should be read out as an alert by screen readers.
In this PR I've
This requires content other than strings to provide the alert separately.
Links
Links to relevent resources.