Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MenuTrigger): closeOnSelect for keyboard users #575

Closed
wants to merge 7 commits into from

Conversation

johnsoter13
Copy link
Collaborator

IMPORTANT

Currently, this project is closed to any external contributions. Any pull request made against this project from external sources will likely be closed. If you would like to make changes to this project, please fork this project.

Guide

This "Help" section can be deleted before submitting this pull request.

Update the name of this pull request to reflect the following shape:

{type}/{scope?}/{message}
  • type - A conventional commit type REQUIRED
  • scope - The kabab-case scope of the changes in this request
  • message - A short, kebab-case statement describing the changes REQUIRED

Provide a general summary of the scope of the changes in this pull request.

Description

Close on select only works for clicks, but not keyboard presses
The full description of the changes made in this request.

  • Added onKeyDown handling to close menu when user hits space or enter and onCloseSelect is true

Links

https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-549363
Links to relevent resources.

@nataliadelmar nataliadelmar added the validated If the pull request is validated automation. label Aug 12, 2024
@nataliadelmar
Copy link
Collaborator

Hmmm maybe Im not getting the purpose of this change, but I can see in master storybook that closeOnSelect works for both click and kb

Screen.Recording.2024-08-13.at.1.52.25.PM.mov

@johnsoter13 johnsoter13 reopened this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants