-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: Automated tokens #268
base: master
Are you sure you want to change the base?
DO NOT MERGE: Automated tokens #268
Conversation
core/color/functional.json
Outdated
@@ -45,63 +14,95 @@ | |||
"80": "rgba(0, 0, 0, 0.8)", | |||
"90": "rgba(0, 0, 0, 0.9)", | |||
"95": "rgba(0, 0, 0, 0.95)", | |||
"100": "rgba(0, 0, 0, 1)" | |||
"100": "#000000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of this is in rgba in the Figma file. Why does it appear in hex here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see below comment
core/color/functional.json
Outdated
"90": "#0e2b20", | ||
"95": "#0a1c15", | ||
"100": "#07120d", | ||
"105": "#4e6961" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see green-105 in the Figma file. Where did this come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It must have been there before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, if this won't be merged anyways then it will not be a problem
core/color/functional.json
Outdated
"95": "#330d0e", | ||
"100": "#1f0a0a" | ||
}, | ||
"transparent": "rgba(255, 255, 255, 0)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, how come could we add this automatically if it is not in the Figma? it is correct that it is here, just wanted to know how did we achieve that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with a soft merge
core/color/functional.json
Outdated
"80": "rgba(255, 255, 255, 0.8)", | ||
"90": "rgba(255, 255, 255, 0.9)", | ||
"95": "rgba(255, 255, 255, 0.95)", | ||
"100": "#ffffff" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as in black-alpha-100: The value of this is in rgba in the Figma file. Why does it appear in hex here?
core/color/gradation.json
Outdated
"light": { | ||
"primary": ["#E6F2F1", "#FFFFFF"], | ||
"secondary": ["#F7FCFC", "#FFFFFF"] | ||
"primary": ["#000000", "#171002"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see 1F1402, 171002 in the Figma, not 000000, 171002
core/color/gradation.json
Outdated
"primary": ["#E6F2F1", "#FFFFFF"], | ||
"secondary": ["#F7FCFC", "#FFFFFF"] | ||
"primary": ["#000000", "#171002"], | ||
"secondary": ["#000000", "#171002"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, I see 2E2515 instaed of 000000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same in all gradation colours tbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing that that is because the design-tokens branch hasn't been updated properly. We should double check these values before merge, but i think once the token assets get updated, this will be resolved (need to run a new publish with design token branch)
Update to the new tokens (automated)
validate the format :D