✨ Add a source to scores #1431
Merged
✨ Add a source to scores #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 files 24 suites 18s ⏱️ Results for commit 36c80e4. ♻️ This comment has been updated with latest results. |
chris-rock
reviewed
Sep 18, 2024
policy/cnspec_policy.proto
Outdated
| @@ -640,6 +640,9 @@ message Score { | |||
| int64 failure_time = 11; | |||
| // risk factors that were applied to this score | |||
| ScoredRiskFactors risk_factors = 12; | |||
| // Source of the score | |||
| // Currently, this only applies to vulnerability scores | |||
| string source = 13; | |||
There was a problem hiding this comment.
I have questions:
- One score can have multiple sources. Eg. MVD can find a CVE and MS defender can find a CVE. Then what lands in the source
- I am not sure a simple string is enough. On GraphQL layer we need to return: source id, source title, source icon. How do we achieve that without storing all the data all the time. eg. we track a list of data sources per space and then refer ids?
There was a problem hiding this comment.
I recommend we do the following:
// Source is used to identify the source.
message Source {
// Required. Name of the source
string name = 1;
// Optional. URL of the source
string url = 2;
}
There was a problem hiding this comment.
Thanks for the suggestion. I changed it accordingly.
Signed-off-by: Christian Zunker <[email protected]>
czunker
force-pushed
the
czunker/score_source
branch
from
f31d8ec to
77f3d47
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.