🐛 filter policies without removing them from the bundle #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing policies from the bundle on filter calls actually caused havoc because it removed potentially dependent policies from the bundle. For example: if you bundle has policy A + B, and B depends on A, and you set `--policy` to `B`, then A gets removed from the bundle and leads to errors. We only need to remove the policy from the list of executed policies in the resolver, not from the bundle itself. Signed-off-by: Dominik Richter <[email protected]>
imilchev
approved these changes
Nov 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing policies from the bundle on filter calls actually caused havoc because it removed potentially dependent policies from the bundle. For example: if you bundle has policy A + B, and B depends on A, and you set
--policytoB, then A gets removed from the bundle and leads to errors.We only need to remove the policy from the list of executed policies in the resolver, not from the bundle itself.