🐛 Try to make mquery checksums stable #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaym
commented
Nov 16, 2023
jaym
commented
- We cannot change a value of the mquery before its stored. This causes the checksum to change. Its better we do this before we calculate checksums. I've made this happen when the bundle is compiled
- The queries variants refer to need to have their checksums before we checksum it. So we need to topologically sort the queries before compiling such that all dependent queries have been compiled and checksummed before compiling the depending query.
- We cannot change a value of the mquery before its stored. This causes the checksum to change. Its better we do this before we calculate checksums. I've made this happen when the bundle is compiled - The queries variants refer to need to have their checksums before we checksum it. So we need to topologically sort the queries before compiling such that all dependant queries have been compiled and checksummed before compiling the depending query.
preslavgerchev
approved these changes
Nov 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.