hotfix invalid return type (#84)

* hotfix invalid return type

* version bump

Controller/Payment/Checkout/AbstractPaymentController.php

@@ -89,39 +89,41 @@ public function __construct(
         $this->jsonResultFactory = $jsonResultFactory;
     }
 
+
     /**
-     * Redirect user to url
+     * Redirect to url
      *
      * @param string $path
-     * @return void
+     * @return ResponseInterface
      */
     protected function redirect($path)
     {
         $this->redirect->redirect($this->response, $path);
+        return $this->response;
     }
 
     /**
      * Process exceptions
      *
      * @param \Exception $e
      * @param string $message
-     * @return void
+     * @return ResponseInterface
      */
     protected function processException(\Exception $e, $message)
     {
         $this->messageManager->addExceptionMessage($e, __($message));
-        $this->redirect('checkout/cart');
+        return $this->redirect('checkout/cart');
     }
 
     /**
      * Redirect with error message
      *
      * @param string $message
-     * @return void
+     * @return ResponseInterface
      */
     protected function redirectWithErrorMessage($message)
     {
         $this->messageManager->addErrorMessage(__($message));
-        $this->redirect('checkout/cart');
+        return $this->redirect('checkout/cart');
     }
 }

Controller/Payment/Checkout/Cancel.php

@@ -9,6 +9,6 @@ class Cancel extends AbstractPaymentController
      */
     public function execute()
     {
-        $this->redirectWithErrorMessage('Mondu: Order has been canceled');
+        return $this->redirectWithErrorMessage('Mondu: Order has been canceled');
     }
 }

Controller/Payment/Checkout/Decline.php

@@ -9,6 +9,6 @@ class Decline extends AbstractPaymentController
      */
     public function execute()
     {
-        $this->redirectWithErrorMessage('Mondu: Order has been declined');
+        return $this->redirectWithErrorMessage('Mondu: Order has been declined');
     }
 }

Controller/Payment/Checkout/Success.php

@@ -42,12 +42,12 @@ public function execute()
                     $this->orderSender->send($order);
                 }
             }
-            $this->redirect('checkout/onepage/success/');
+            return $this->redirect('checkout/onepage/success/');
 
         } catch (LocalizedException $e) {
-            $this->processException($e, 'Mondu: An error occurred while trying to confirm the order');
+            return $this->processException($e, 'Mondu: An error occurred while trying to confirm the order');
         } catch (\Exception $e) {
-            $this->processException($e, 'Mondu: Error during the order process');
+            return $this->processException($e, 'Mondu: Error during the order process');
         }
     }
 }

composer.json

@@ -2,7 +2,7 @@
   "name": "mondu_gmbh/magento2-payment",
   "description": "Mondu payment method for magento 2",
   "type": "magento2-module",
-  "version": "2.1.0",
+  "version": "2.1.1",
   "license": [
     "MIT"
   ],

etc/module.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="Mondu_Mondu" setup_version="2.1.0">
+    <module name="Mondu_Mondu" setup_version="2.1.1">
         <sequence>
             <module name="Magento_Sales"/>
             <module name="Magento_Payment"/>