-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
svg to avif test #2359
base: master
Are you sure you want to change the base?
svg to avif test #2359
Conversation
✅ Deploy Preview for barolo-time-757cf9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
closes #2274? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about other compressed formats? because PNGs will increase the page size a lot
I made an attempt to compress the png's with some small gains. What other file format would you suggest so i can try to see any gains? we're talking about, in some cases,small 16x16 / 64x64 pixel images so i suspect the gains would be minor. on the other hand, there is the mrl-logo which gets drawn at a whopping 1500x1500 in our css lol not sure what thats about |
thanks to @HardenedSteel for exposing me to avif / jpgxl and srcset to attempt to display the not so widely supported jpgxl format and fallback to avif it is as simple as: <img class="matrix"
srcset="/img/matrix-logo.jxl, /img/matrix-logo.avif"
src="/img/matrix-logo.avif"
title="Matrix"
alt="Matrix logo"> all we've done is add the As for this PR i am satisfied with replacing the SVG's with AVIF's with the final TODO being to look at the font files. we can most likely just delete the SVG font files (as the svg is seemingly a fallback for browsers that dont support the standard font types)
|
closes #2274
todo: delete the png files if avifs are OK