ringct: remove unused range proof types and fix serialization bug

[jeffro256]

Remove unused Rangeproof types RangeProofBulletproof , and RangeProofMultiOutputBulletproof. In the prove code, if the RangeProofBulletproof enum was passed, then one bulletproof was created per output. If RangeProofMultiOutputBulletproof was passed, then K bulletproofs were produced, where K is the number of one bits in the count of the outputs, Neither of these are allowed by consensus:

monero/src/cryptonote_basic/cryptonote_format_utils.cpp

Lines 150 to 154 in 2226d4f

	if (rv.p.bulletproofs_plus.size() != 1)
	{
	LOG_PRINT_L1("Failed to parse transaction from blob, bad bulletproofs_plus size in tx " << get_transaction_hash(tx));
	return false;
	}

and

monero/src/cryptonote_basic/cryptonote_format_utils.cpp

Lines 174 to 178 in 2226d4f

	if (rv.p.bulletproofs.size() != 1)
	{
	LOG_PRINT_L1("Failed to parse transaction from blob, bad bulletproofs size in tx " << get_transaction_hash(tx));
	return false;
	}

.

Also fixes an actual bug with the boost serialization of type tools::wallet2::signed_tx_set. If the serialized payload has a version < 4, then the range proof type is assumed to be RangeProofBulletproof, which is incorrect.

[selsta]

Compilation issues with some CI jobs

[jeffro256]

Oops sorry I only pushed some of the commits

[iamamyth]

Looks like there's still one failing unit test:
select_outputs.exact_unlock_block

[jeffro256]

That test should be unrelated, and fails sporadically.

[iamamyth]

Agreed, unrelated.