Skip to content

chore(web): make sure that onTrackRef always set to latest prop value #7049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

gribnoysup
Copy link
Collaborator

@gribnoysup gribnoysup commented Jun 23, 2025

Small drive-by fix (spotted when looking for something else): spotted that we broke the onTrack behavior when removing tracking from logger. Also renamed the methods as they weren't updated with the changes that separated tracking from logging

@gribnoysup gribnoysup requested a review from a team as a code owner June 23, 2025 14:33
@gribnoysup gribnoysup added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Jun 23, 2025
@gribnoysup gribnoysup merged commit 1b4d8fd into main Jun 24, 2025
57 of 60 checks passed
@gribnoysup gribnoysup deleted the fix-track-function-ref-update branch June 24, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants