feat(data-modeling): add rename collection to side panel COMPASS-9658 #7174
+244
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
added
the
feature flagged
gribnoysup
reviewed
Aug 7, 2025
Comment on lines
+363
to
+370
| dispatch(applyEdit(edit)); | ||
|
|
||
| // When renaming we want to keep the renamed collection selected in the UI, | ||
| // the ID is the collection name. | ||
| dispatch({ | ||
| type: DiagramActionTypes.COLLECTION_SELECTED, | ||
| namespace: toNS, | ||
| }); |
There was a problem hiding this comment.
Batch updates are an antipattern, reducer should be the one accounting for that instead of multiple events being dispatched
There was a problem hiding this comment.
Because APPLY_EDIT is somewhat of a generic action with subactions itself, we can in theory apply this redux pattern where you create a case reducer (not a slice, just another reducer that expects only a certain type of action) and move the logic of handling applies there. No strong opinion here, definitely might be an overkill, but this would be a second case for something like that for this action already 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-9658
Opening as a draft, there's a TODO in this code that I have an open thread in the tech design on: https://docs.google.com/document/d/15Dn5FB3POEj9sYQrYIUajZySqFzlPfpcgjkPhzFqSFg/edit?disco=AAABnqG-O7o
Adding e2e tests for this in the next pr that has remove collection.
rename.collection.mp4