Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-6212): generate sarif report and upload sbom file to s3 #178

Merged
merged 6 commits into from
Jun 13, 2024

Conversation

baileympearson
Copy link
Collaborator

@baileympearson baileympearson commented Jun 12, 2024

Description

What is changing?

Sarif reports are generated and upload to s3 during the release process.

sbom lite files are also uploaded.

Example release upload for kerberos:

Screenshot 2024-06-12 at 10 48 25 AM

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title add sarif report generation to kereros chore(NODE-6212): generate sarif report during releases Jun 12, 2024
@baileympearson baileympearson marked this pull request as ready for review June 12, 2024 16:54
@baileympearson baileympearson changed the title chore(NODE-6212): generate sarif report during releases chore(NODE-6212): generate sarif report and upload sbom file to s3 Jun 12, 2024
@durran durran self-assigned this Jun 13, 2024
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 13, 2024
durran
durran previously approved these changes Jun 13, 2024
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 13, 2024
@durran durran merged commit 2e71058 into main Jun 13, 2024
10 of 11 checks passed
@durran durran deleted the generate-sarif-report-kerberos branch June 13, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants