Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-6186): add downloading to FLE build script #5

Merged
merged 10 commits into from
May 30, 2024
Merged

Conversation

nbbeeken
Copy link
Collaborator

Description

What is changing?

  • We now download a prebuild of libmongocrypt instead of building from source.
  • --build, -b will still build from source
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Now we do not need to have cmake or other toolchain requirements satisfied for libmongocrypt only what is needed for the bindings.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken changed the title chore: add downloading to FLE build script chore(NODE-6186): add downloading to FLE build script May 22, 2024
@durran durran self-assigned this May 30, 2024
@durran durran added the Team Review Needs review from team label May 30, 2024
@durran durran merged commit 4292689 into main May 30, 2024
9 of 10 checks passed
@durran durran deleted the chore-download branch May 30, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants