feat(NODE-6773): add multiple collinfo option #70
Conversation
addon/mongocrypt.cc
Outdated
| @@ -577,6 +577,8 @@ MongoCrypt::MongoCrypt(const CallbackInfo& info) : ObjectWrap(info) { | |||
|
|
|||
| mongocrypt_setopt_retry_kms(mongo_crypt(), true); | |||
|
|
|||
| mongocrypt_setopt_enable_multiple_collinfo(mongo_crypt()); | |||
There was a problem hiding this comment.
Note: The driver may need a way to know if this is set
There was a problem hiding this comment.
This shouldn't be necessary, only an updated libmongocrypt will request more than one collInfo
There was a problem hiding this comment.
Isn't the issue when an updated libmongocrypt interacts with a driver that isn't updated though (i.e., driver pre 6.14)?
There was a problem hiding this comment.
Yeah, unfortunately having moved the JS code for the bindings into the driver means that that's a case we now need to handle – this option would have to be passed from JS to the constructor instead of being set unconditionally
There was a problem hiding this comment.
Added a new option to control this, not sure how I would test this here since you can't inspect the properties of the struct (of course) and there doesn't seem to be a getopt API.
We can flip the option in the driver, and your $lookups fail as a result.
nbbeeken
changed the title
Description
What is changing?
In support of: mongodb/node-mongodb-native#4427
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Enables multiple collection info support for $lookup aggregations
Calls
mongocrypt_setopt_enable_multiple_collinfoto enable the settingDouble check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript