Skip to content

chore: fix local run and vulnerabilities #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix local run and vulnerabilities #360

wants to merge 1 commit into from

Conversation

blva
Copy link
Collaborator

@blva blva commented Jul 14, 2025

Proposed changes

  • Ran npm audit fix
  • Added an oidc lib override to fix local run of npm run test in node 23

Checklist

@blva blva marked this pull request as ready for review July 14, 2025 15:41
@Copilot Copilot AI review requested due to automatic review settings July 14, 2025 15:41
@blva blva requested a review from a team as a code owner July 14, 2025 15:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates vulnerable dependencies and ensures local OIDC plugin compatibility.

  • Bumps @mongodb-js/devtools-connect and @mongosh/service-provider-node-driver to address security issues
  • Adds an overrides section to pin @mongodb-js/oidc-plugin at version 1.1.8 for local runs
Comments suppressed due to low confidence (2)

package.json:80

  • [nitpick] Consider adding a comment or note explaining why the @mongodb-js/oidc-plugin override is needed, so future maintainers understand its purpose.
  "overrides": {

package.json:65

  • After bumping these dependency versions, please update and commit the lockfile (e.g., package-lock.json or yarn.lock) to ensure reproducible installs.
    "@mongodb-js/devtools-connect": "^3.9.2",

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 16271352682

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 75.33%

Files with Coverage Reduction New Missed Lines %
src/common/atlas/apiClient.ts 2 65.14%
Totals Coverage Status
Change from base Build 16220557964: 0.06%
Covered Lines: 887
Relevant Lines: 1087

💛 - Coveralls

@fmenezes
Copy link
Collaborator

should we close it given #363 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants