chore: enable some eslint rules #426
Merged
+16
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables additional ESLint and TypeScript linting rules to improve code quality and consistency. The changes include enabling strict equality checks, preventing self-comparisons, and ensuring functions have explicit return values.
- Enables
noImplicitReturnsTypeScript compiler option and several new ESLint rules - Replaces loose equality operators (
==,!=) with strict equality operators (===,!==) throughout the codebase - Adds explicit
return undefinedstatements to functions that previously had implicit undefined returns
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.build.json | Enables noImplicitReturns TypeScript compiler option |
| eslint.config.js | Adds new ESLint rules for strict equality, self-comparison prevention, and other quality checks |
| src/tools/atlas/connect/connectCluster.ts | Replaces loose equality operators with strict equality operators |
| src/common/atlas/cluster.ts | Replaces loose equality operators with strict equality operators |
| src/common/atlas/apiClient.ts | Replaces loose equality operators with strict equality and adds explicit return statements |
| @@ -48,6 +48,10 @@ export default defineConfig([ | |||
| rules: { | |||
| "@typescript-eslint/switch-exhaustiveness-check": "error", | |||
| "@typescript-eslint/no-non-null-assertion": "error", | |||
| eqeqeq: "error", | |||
| "no-self-compare": "error", | |||
| "no-unassigned-vars": "error", | |||
There was a problem hiding this comment.
The ESLint rule name has a typo. It should be "no-unused-vars" instead of "no-unassigned-vars".
Suggested change
| "no-unassigned-vars": "error", | |
| "no-unused-vars": "error", |
Copilot uses AI. Check for mistakes.
himanshusinghs
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Enables a few extra eslint/ts rules and fixes the issues detected by them:
Checklist