feat: improve logging and testing, allow using id tokens instead of access tokens #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miscellaneous improvements around logging inside the plugin, plus a few preparations for downstream diagnostics improvements: - Emit an event when the browser has successfully been opened (COMPASS-8121) - Improve logging around token refreshing (MONGOSH-1795) - Emit acquired tokens in an event (MONGOSH-1845) - Use `.timers` for also testing the browser timer
addaleax
changed the title
Anemy
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: improve logging and testing
Miscellaneous improvements around logging inside the plugin, plus a few preparations
for downstream diagnostics improvements:
.timersfor also testing the browser timerfeat: allow using id tokens instead of access tokens MONGOSH-1843