Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SBOM handling action #13

Merged
merged 13 commits into from
Jun 6, 2024
Merged

Conversation

blink1073
Copy link
Member

Fixes #8.

Tested with mongodb/winkerberos#88

image

@blink1073 blink1073 requested a review from alcaeus May 24, 2024 18:23
@blink1073 blink1073 requested a review from baileympearson May 24, 2024 18:24
@blink1073 blink1073 marked this pull request as draft May 29, 2024 14:23
@blink1073
Copy link
Member Author

TODO: we should update the SBOM first, to ensure it is up to date.

@blink1073
Copy link
Member Author

TODO: we should update the SBOM first, to ensure it is up to date.

We're going to defer this for now.

@blink1073 blink1073 marked this pull request as ready for review June 3, 2024 11:12
@alcaeus
Copy link
Collaborator

alcaeus commented Jun 4, 2024

Heads up, I'll need a while until I can test this, as I'm only now migrating PHP to the v2 version of the tools. If another driver is in position to test this, I'd very much appreciate it. // cc @baileympearson

Copy link
Collaborator

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for PHPLIB, and the action itself works (but our Silk setup isn't complete yet, so there's no SBOM to be found). With that in mind, I think we can merge this and re-tag v2 to make it available.
Just left suggestions to fix the repository name in the readme ;)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
blink1073 and others added 3 commits June 6, 2024 08:19
@blink1073 blink1073 merged commit 1ee01fc into mongodb-labs:main Jun 6, 2024
3 checks passed
@blink1073 blink1073 deleted the test-pypi branch June 6, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SBOM Handling Action
2 participants