-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(EAI-598) [UI] Investigate further code splitting #563
Conversation
// TODO: Use this to animate the transition after https://jira.mongodb.org/browse/LG-3965 is merged. | ||
// const ratingCommentInputVisible = hasRating && status !== "submitted" && status !== "abandoned"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we have ticket for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (mostly based on trust). what do you think is the actual performance impact of this? like how many MS imprvoement on load time?
Honestly pretty minimal, though we'd need to test to get actual numbers. Should have some small effect though. |
Jira: (EAI-598) [UI] Investigate further code splitting
Changes
Before (current
main
):After (this PR):