-
Notifications
You must be signed in to change notification settings - Fork 73
(EAI-428) versioned docs #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* remove snooty prefix * ingesting pages for all branches on each data source * do not ingest (and delete if already exists) pages on inactive branches * handle current version override * cleanup unused code from previous version override implementation, tests * update SnootyDataSource tests * remove override for docs current version
$or: [ | ||
{ "metadata.version.isCurrent": { $exists: false } }, | ||
{ "metadata.version.isCurrent": true }, | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to do the same type of thing for the code example dataset? https://huggingface.co/datasets/mongodb-eai/code-examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do need to add that to the filter for the code example dataset, thanks for catching. Code examples will be complicated by the fact that we're filtering for source names that contain snooty
or devcenter
, and we removed the snooty prefix - https://github.com/mongodb/chatbot/blob/EAI-428-feature-versioned-docs/packages/datasets/src/mongoDbDatasetConstants.ts#L19-L22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The best solution is to filter by content type field, which will be done in EAI-1001. Adding a DO NOT MERGE flag to this until I can add that ticket to this PR, and update the filter for the code example dataset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. just few small things to fix before merge
Jira: https://jira.mongodb.org/browse/EAI-428
Changes
Notes