-
Notifications
You must be signed in to change notification settings - Fork 24
[WIP] Atlas search lookups #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
WaVEV
wants to merge
20
commits into
mongodb:main
Choose a base branch
from
WaVEV:atlas-search-lookups
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,242
−28
Draft
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d116fe3
Create django_mongodb_backend.expressions package
timgraham 339c57f
First approach.
WaVEV a4a98b8
Add SearchExpressions
WaVEV 580c729
Add test
WaVEV 12f5763
Refactor.
WaVEV 435308b
Add search index test
WaVEV d67aec1
Add moreLikeThis lookup.
WaVEV 7225586
CombinedSearchExpression
WaVEV 6cf4441
Add vector search expression.
WaVEV 33d33f1
Add combinable operators.
WaVEV 82ee197
Edits
WaVEV 72f50af
Add __str__ method
WaVEV 26090cc
Add combined expressions test.
WaVEV 39c38d3
Add vector search test.
WaVEV 4a121f5
Add combinable test
WaVEV f19033b
Refactor
WaVEV 48f630e
Remove unused parameter
WaVEV 4969c75
Fix unit test
WaVEV a71083f
Move search expression to expression/search
WaVEV 7a8136a
Improve unit test.
WaVEV File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,4 +81,4 @@ repos: | |
rev: "v2.2.6" | ||
hooks: | ||
- id: codespell | ||
args: ["-L", "nin"] | ||
args: ["-L", "nin", "-L", "searchin"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to preserve this function for the future, probably want to make hybrid search and this part of the code could be useful. I know that it is weird, check the replacement
len
as 1 and then iterate over it. Also the exception could be raised before this point. Let me know if you want me to refactor this code.