Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVG-17874: Update Genny with --no-activate flag. #873

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johndaniels
Copy link
Collaborator

This allows us to create task generation tasks that don't immediately execute all the generated variants.

It's a bit awkward to pass through a flag that is phrased in the negative (as opposed to using an "activate" flag and variable), but in this case we need to because an explicit activate flag would have different behavior than the default of not specifying the "activate" parameter. If the "activate" parameter is present on a task, then that task is always activated, but if it is not present then it defaults to if the version is activated or through batchtime.

Thanks for submitting a PR to the Genny repo. Please include the following fields (if relevant) prior to submitting your PR.

Jira Ticket: < Ticket Number >

Whats Changed:
High level explanation of changes

Patch testing results:
If applicable, link a patch test showing code changes running successfully

Workload Submission form:
If applicable, only required if there is a new workload being added. Form can be found here

Related PRs:
If applicable, link related PRs

PLEASE READ AND REMOVE THE SECTION BELOW BEFORE SUBMITTING YOUR PR FOR REVIEW

  1. Once (1) you get approval from the STM or the Product Perf team for your change and (2) all your CI tests pass, you can initiate a merge by entering a comment on your PR with the text

    evergreen merge

    This kicks your PR into the evergreen commit queue. Evergreen will automatically squash-merge your commit after checking that you have PR approval and that the CI tests all pass.

This allows us to create task generation tasks that don't
immediately execute all the generated variants.

It's a bit awkward to pass through a flag that is phrased in the
negative (as opposed to using an "activate" flag and variable),
but in this case we need to because an explicit activate flag
would have different behavior than the default of not specifying
the "activate" parameter. If the "activate" parameter is present
on a task, then that task is always activated, but if it is not
present then it defaults to if the version is activated or through
batchtime.
@johndaniels johndaniels requested a review from a team April 23, 2023 21:59
@thessem
Copy link
Collaborator

thessem commented Apr 24, 2023

It is going to take me a little bit of time to be able to review this one. There are a few things going on (unplumbing of genny_repo_root which doesn't seem to have been used anyway, modification of exec_timeout_secs in a test without any non-test code seemingly breaking? then again, CI is failing right now....) that are probably obvious with enough context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants