Skip to content

Commit

Permalink
Adam/react 18 migration fork (#1832)
Browse files Browse the repository at this point in the history
* Adds Combobox tests (#1811)

* Adds todo tests

* Update Combobox.spec.tsx

* lint

* Update Combobox.spec.tsx

* Update SearchResultsMenu.story.tsx (#1813)

* [INTEGRATION LG-3296] Build Pipeline (#1812)

* Adam/tsconfig (#1806)

* lerna exec. extend build.tsconfig

* updates internal tsconfig

* rm old tsconfigs

* rm legacy script

* init config/package.json

* updates paths

* updates check:ts script

* Update create-package.js

* check:ts also builds dependents

* Build tooling (#1807)

* lerna exec. extend build.tsconfig

* updates internal tsconfig

* updates paths

* Create update-package-json.ts

* Update package.json

* add tsc to package.json

* adds turbo

* Create turbo.yml

* Update package.json

* update ci

* Update turbo.json

* rm cycle

* updates CI

* Setup nx vs turbo benchmark job

* Update benchmark.yml

* rename lint script

* rm yarn cache

* Update turbo.json

* update build dependencies

* Adds baseline job

* Updates configs & ci

Update turbo.json

Update turbo.json

Update nx.json

Update benchmark.yml

restore build-storybook

fixes dependencies

Create sizeDiff.yml

Update sizeDiff.yml

Update sizeDiff.yml

Update .npmpackagejsonlintrc.json

rm lodash from icon-button

rm bad references from palette story

fix nx?

* removes nx.json

* Delete update-package-json.ts

* Update Palette.story.tsx

* Update Palette.story.tsx

* Update .gitignore

* rm build:turbo

* fix story build error

* fix split button & menu story imports

* Adds federation icon (#1827)

* Fix release script (#1828)

* LG-3358, LG-3385 - Change Lottie dependency (#1826)

* change lottie deps

* changeset

---------

Co-authored-by: brooke <[email protected]>

* Updates icon for dark mode (#1825)

* with changeset (#1824)

* yarn update

* rm resolution

* fix basic TS

* resolve RTG types

* runs implicit-children codemod

* lint

* LG-3667: Updates disabled Radio label (#1831)

* with changeset

* rm console

* use label prop to style

* fix formfooter error (#1833)

* fixes tooltip TS issues

* fix side-nav TS errors (#1834)

* fixes bug introduced

* fix table ts (#1835)

* revert changes to isComponentGlyph (#1836)

* fix sc bugs

* last sc fix

* prettier

* Update examples.spec.tsx

* heap?

* runs lint too

* fix combobox tsc

---------

Co-authored-by: Brooke Scarlett Yalof <[email protected]>
Co-authored-by: Sean Park <[email protected]>
Co-authored-by: Shaneeza <[email protected]>
  • Loading branch information
4 people authored Jul 11, 2023
1 parent 0e1b059 commit ba72b7c
Show file tree
Hide file tree
Showing 232 changed files with 6,251 additions and 9,413 deletions.
5 changes: 5 additions & 0 deletions .changeset/gentle-shoes-join.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@leafygreen-ui/text-input': patch
---

Updates valid state icon in dark mode to match Figma spec
5 changes: 5 additions & 0 deletions .changeset/little-comics-deny.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@leafygreen-ui/loading-indicator': major
---

Changing Lottie dependency from @lottie-files/react-lottie-player to react-lottie-player
5 changes: 5 additions & 0 deletions .changeset/little-spoons-doubt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@leafygreen-ui/segmented-control': minor
---

Label prop now accepts type `React.ReactNode` instead of `string`
5 changes: 5 additions & 0 deletions .changeset/spicy-hairs-fly.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@leafygreen-ui/radio-group': patch
---

Updates label color when disabled to match Figma spec
5 changes: 5 additions & 0 deletions .changeset/three-lobsters-cough.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@leafygreen-ui/icon': minor
---

Adds 'Federation' icon to glyph set
165 changes: 15 additions & 150 deletions .github/workflows/nodejs.yml → .github/workflows/pr.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Node.js CI
name: Pull Request CI

on:
pull_request:
Expand All @@ -9,80 +9,9 @@ concurrency:
cancel-in-progress: true

jobs:
install:
name: Install node modules
runs-on: ubuntu-latest
steps:
- name: Checkout Repo
uses: actions/checkout@v2

- name: Use Node.js 16
uses: actions/setup-node@v3
with:
node-version: '16'
cache: yarn
cache-dependency-path: 'yarn.lock'

- name: Install
run: yarn install --frozen-lockfile --prefer-offline

outputs:
yarn-cache-dir: ${{ steps.get-yarn-cache-dir.outputs.dir }}

lints:
lint:
name: Check lints
runs-on: ubuntu-latest
needs: install
steps:
- uses: actions/checkout@v2

- name: Use Node.js 16
uses: actions/setup-node@v3
with:
node-version: '16'
cache: yarn
cache-dependency-path: 'yarn.lock'

- run: yarn install --frozen-lockfile --prefer-offline

- name: prettier
run: yarn check:prettier

- name: eslint
run: yarn check:eslint --format junit -o reports/junit/js-lint-results.xml

types:
name: Check types
runs-on: ubuntu-latest
needs: install
steps:
- uses: actions/checkout@v2

- name: Use Node.js 16
uses: actions/setup-node@v3
with:
node-version: '16'
cache: yarn
cache-dependency-path: 'yarn.lock'

- run: yarn install --frozen-lockfile --prefer-offline

- uses: actions/cache/restore@v3
name: Restore TS cache
id: ts-cache
with:
path: |
**/dist/**/*.ts
!**/node_modules
key: ${{ runner.os }}-ts-cache-${{ hashFiles('**/tsconfig.js', '**/package.tsconfig.js', '**/src/', '**/scripts/', '!**/node_modules', '!**/dist') }}

- name: types
run: yarn check:ts

deps:
name: Check dependency list
runs-on: ubuntu-latest
needs: install
steps:
- uses: actions/checkout@v2

Expand All @@ -95,16 +24,15 @@ jobs:

- run: yarn install --frozen-lockfile --prefer-offline

- name: deps
run: yarn check:deps
- name: lint
run: yarn lint

- name: package.json versions
run: yarn check:package-json
outputs:
yarn-cache-dir: ${{ steps.get-yarn-cache-dir.outputs.dir }}

build:
name: Build packages
runs-on: ubuntu-latest
needs: [install, lints]
steps:
- uses: actions/checkout@v2

Expand Down Expand Up @@ -132,44 +60,12 @@ jobs:

- name: build
if: ${{ steps.build-cache.outputs.cache-hit != 'true' }}
run: yarn build:packages

build-ts:
name: Build TypeScript
runs-on: ubuntu-latest
needs: [install, lints]
steps:
- uses: actions/checkout@v2

- uses: actions/cache@v3
name: Check for ts cache
id: ts-cache
with:
path: |
**/dist/**/*.ts
!**/node_modules
key: ${{ runner.os }}-ts-cache-${{ hashFiles('**/tsconfig.js', '**/package.tsconfig.js', '**/src/', '**/scripts/', '!**/node_modules', '!**/dist') }}

- name: Use Node.js 16
if: ${{ steps.ts-cache.outputs.cache-hit != 'true' }}
uses: actions/setup-node@v3
with:
node-version: '16'
cache: yarn
cache-dependency-path: 'yarn.lock'

- name: Install
if: ${{ steps.ts-cache.outputs.cache-hit != 'true' }}
run: yarn install --frozen-lockfile --prefer-offline

- name: build-ts
if: ${{ steps.ts-cache.outputs.cache-hit != 'true' }}
run: yarn build:ts
run: yarn build

chromatic:
name: Chromatic
runs-on: ubuntu-latest
needs: [install, build]
needs: [build]
steps:
- name: Checkout
uses: actions/checkout@v2
Expand Down Expand Up @@ -205,7 +101,7 @@ jobs:
tests:
name: Run tests
runs-on: ubuntu-latest
needs: [install, build]
needs: [build]
steps:
- uses: actions/checkout@v2

Expand Down Expand Up @@ -235,7 +131,7 @@ jobs:
tests-ssr:
name: Run tests with artificial server rendering
runs-on: ubuntu-latest
needs: [install, build]
needs: [build]
steps:
- uses: actions/checkout@v2

Expand All @@ -262,10 +158,10 @@ jobs:
env:
JEST_JUNIT_OUTPUT: 'reports/junit/js-test-ssr-results.xml'

checkBuilds:
name: Verify builds
validate-builds:
name: Validate builds & dependencies
runs-on: ubuntu-latest
needs: [install, build, build-ts]
needs: [build]
steps:
- uses: actions/checkout@v2

Expand Down Expand Up @@ -296,36 +192,5 @@ jobs:
!**/node_modules
key: ${{ runner.os }}-ts-cache-${{ hashFiles('**/tsconfig.js', '**/package.tsconfig.js', '**/src/', '**/scripts/', '!**/node_modules', '!**/dist') }}

- name: check builds
run: yarn check:builds

sizeDiff:
name: Check file size
runs-on: ubuntu-latest
needs: install
steps:
- uses: actions/checkout@v2

- name: Use Node.js 16
uses: actions/setup-node@v3
with:
node-version: '16'
cache: yarn
cache-dependency-path: 'yarn.lock'

- run: yarn install --frozen-lockfile --prefer-offline

- uses: actions/cache/restore@v3
name: Restore build cache
id: build-cache
with:
path: |
**/dist
!**/node_modules
key: ${{ runner.os }}-build-cache-${{ hashFiles('**/rollup.config.js', '**/babel.config.js', '**/src/', '**/scripts/', '!**/node_modules', '!**/dist') }}

- uses: preactjs/compressed-size-action@v2
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
clean-script: 'clean:builds && clean:modules'
build-script: 'build:packages'
- name: validate
run: yarn validate
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ jobs:
run: yarn

- name: Build packages
run: yarn build:packages
run: yarn build

- name: Build typescript
run: yarn build:ts
run: yarn tsc

- name: Build TSDoc
run: yarn docs:tsdoc
run: yarn build:docs

- name: Establish Chromatic baseline
uses: chromaui/action@v1
Expand Down
36 changes: 36 additions & 0 deletions .github/workflows/sizeDiff.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
name: File Size

on:
pull_request:
types: [opened, synchronize, reopened]

jobs:
sizeDiff:
name: Check file size
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2

- name: Use Node.js 16
uses: actions/setup-node@v3
with:
node-version: '16'
cache: yarn
cache-dependency-path: 'yarn.lock'

- run: yarn install --frozen-lockfile --prefer-offline

- uses: actions/cache/restore@v3
name: Restore build cache
id: build-cache
with:
path: |
**/dist
!**/node_modules
key: ${{ runner.os }}-build-cache-${{ hashFiles('**/rollup.config.js', '**/babel.config.js', '**/src/', '**/scripts/', '!**/node_modules', '!**/dist') }}

- uses: preactjs/compressed-size-action@v2
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
clean-script: 'clean'
build-script: 'build'
20 changes: 0 additions & 20 deletions .github/workflows/test-dispatch.yml

This file was deleted.

3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,5 @@ packages/**/stories.js*
# Storybook/Chromatic logs
build-storybook.log

.turbo
.turbo
scripts/tmp.*.ts
2 changes: 1 addition & 1 deletion .npmpackagejsonlintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{
"patterns": ["./packages/code/package.json"],
"rules": {
"prefer-caret-version-dependencies": "warning"
"prefer-caret-version-dependencies": "off"
}
}
]
Expand Down
2 changes: 1 addition & 1 deletion STYLEGUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export const someConstant = {
optionTwo = 'option 2',
} as const;

export type someConstant = typeof someConstant[keyof typeof someConstant];
export type someConstant = (typeof someConstant)[keyof typeof someConstant];
```

#### Avoid
Expand Down
Loading

0 comments on commit ba72b7c

Please sign in to comment.