Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adam/react 18 migration fork #1832

Merged
merged 33 commits into from
Jul 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
a9f3731
Adds Combobox tests (#1811)
TheSonOfThomp Jun 20, 2023
933f3ba
Update SearchResultsMenu.story.tsx (#1813)
TheSonOfThomp Jun 21, 2023
7124b78
[INTEGRATION LG-3296] Build Pipeline (#1812)
TheSonOfThomp Jun 23, 2023
bf5672b
Adds federation icon (#1827)
bruugey Jul 6, 2023
3309d35
Fix release script (#1828)
bruugey Jul 6, 2023
61c60ab
LG-3358, LG-3385 - Change Lottie dependency (#1826)
spark33 Jul 7, 2023
0efcd4e
Updates icon for dark mode (#1825)
bruugey Jul 7, 2023
b0b70b7
with changeset (#1824)
bruugey Jul 7, 2023
f07e995
yarn update
TheSonOfThomp Jul 7, 2023
9055548
rm resolution
TheSonOfThomp Jul 7, 2023
7d3f404
fix basic TS
TheSonOfThomp Jul 7, 2023
66c7d01
resolve RTG types
TheSonOfThomp Jul 7, 2023
3217488
runs implicit-children codemod
TheSonOfThomp Jul 7, 2023
c26e85d
lint
TheSonOfThomp Jul 7, 2023
6c1b992
LG-3667: Updates disabled Radio label (#1831)
bruugey Jul 10, 2023
a2f9711
fix formfooter error (#1833)
shaneeza Jul 10, 2023
686d908
fixes tooltip TS issues
bruugey Jul 10, 2023
0dfd10b
Merge branch 'adam/react-18-migration-fork' of github.com:mongodb/lea…
bruugey Jul 10, 2023
9a83d83
fix side-nav TS errors (#1834)
shaneeza Jul 10, 2023
51d7987
fixes bug introduced
bruugey Jul 10, 2023
36878a5
Merge branch 'adam/react-18-migration-fork' of github.com:mongodb/lea…
bruugey Jul 10, 2023
830ada6
fix table ts (#1835)
TheSonOfThomp Jul 10, 2023
97a4b63
revert changes to isComponentGlyph (#1836)
shaneeza Jul 10, 2023
113eb9b
fix sc bugs
bruugey Jul 10, 2023
72dd25b
Merge branch 'adam/react-18-migration-fork' of github.com:mongodb/lea…
bruugey Jul 10, 2023
2457b84
last sc fix
bruugey Jul 10, 2023
16163c7
prettier
shaneeza Jul 10, 2023
72b475c
Update examples.spec.tsx
TheSonOfThomp Jul 10, 2023
f82f0bd
Merge remote-tracking branch 'origin' into adam/react-18-migration-fork
bruugey Jul 11, 2023
46f1758
heap?
bruugey Jul 11, 2023
0b93464
Merge branch 'adam/react-18-migration-fork' of github.com:mongodb/lea…
bruugey Jul 11, 2023
bc4b3e6
runs lint too
bruugey Jul 11, 2023
fd080f5
fix combobox tsc
bruugey Jul 11, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gentle-shoes-join.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@leafygreen-ui/text-input': patch
---

Updates valid state icon in dark mode to match Figma spec
5 changes: 5 additions & 0 deletions .changeset/little-comics-deny.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@leafygreen-ui/loading-indicator': major
---

Changing Lottie dependency from @lottie-files/react-lottie-player to react-lottie-player
5 changes: 5 additions & 0 deletions .changeset/little-spoons-doubt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@leafygreen-ui/segmented-control': minor
---

Label prop now accepts type `React.ReactNode` instead of `string`
5 changes: 5 additions & 0 deletions .changeset/spicy-hairs-fly.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@leafygreen-ui/radio-group': patch
---

Updates label color when disabled to match Figma spec
5 changes: 5 additions & 0 deletions .changeset/three-lobsters-cough.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@leafygreen-ui/icon': minor
---

Adds 'Federation' icon to glyph set
165 changes: 15 additions & 150 deletions .github/workflows/nodejs.yml → .github/workflows/pr.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Node.js CI
name: Pull Request CI

on:
pull_request:
Expand All @@ -9,80 +9,9 @@ concurrency:
cancel-in-progress: true

jobs:
install:
name: Install node modules
runs-on: ubuntu-latest
steps:
- name: Checkout Repo
uses: actions/checkout@v2

- name: Use Node.js 16
uses: actions/setup-node@v3
with:
node-version: '16'
cache: yarn
cache-dependency-path: 'yarn.lock'

- name: Install
run: yarn install --frozen-lockfile --prefer-offline

outputs:
yarn-cache-dir: ${{ steps.get-yarn-cache-dir.outputs.dir }}

lints:
lint:
name: Check lints
runs-on: ubuntu-latest
needs: install
steps:
- uses: actions/checkout@v2

- name: Use Node.js 16
uses: actions/setup-node@v3
with:
node-version: '16'
cache: yarn
cache-dependency-path: 'yarn.lock'

- run: yarn install --frozen-lockfile --prefer-offline

- name: prettier
run: yarn check:prettier

- name: eslint
run: yarn check:eslint --format junit -o reports/junit/js-lint-results.xml

types:
name: Check types
runs-on: ubuntu-latest
needs: install
steps:
- uses: actions/checkout@v2

- name: Use Node.js 16
uses: actions/setup-node@v3
with:
node-version: '16'
cache: yarn
cache-dependency-path: 'yarn.lock'

- run: yarn install --frozen-lockfile --prefer-offline

- uses: actions/cache/restore@v3
name: Restore TS cache
id: ts-cache
with:
path: |
**/dist/**/*.ts
!**/node_modules
key: ${{ runner.os }}-ts-cache-${{ hashFiles('**/tsconfig.js', '**/package.tsconfig.js', '**/src/', '**/scripts/', '!**/node_modules', '!**/dist') }}

- name: types
run: yarn check:ts

deps:
name: Check dependency list
runs-on: ubuntu-latest
needs: install
steps:
- uses: actions/checkout@v2

Expand All @@ -95,16 +24,15 @@ jobs:

- run: yarn install --frozen-lockfile --prefer-offline

- name: deps
run: yarn check:deps
- name: lint
run: yarn lint

- name: package.json versions
run: yarn check:package-json
outputs:
yarn-cache-dir: ${{ steps.get-yarn-cache-dir.outputs.dir }}

build:
name: Build packages
runs-on: ubuntu-latest
needs: [install, lints]
steps:
- uses: actions/checkout@v2

Expand Down Expand Up @@ -132,44 +60,12 @@ jobs:

- name: build
if: ${{ steps.build-cache.outputs.cache-hit != 'true' }}
run: yarn build:packages

build-ts:
name: Build TypeScript
runs-on: ubuntu-latest
needs: [install, lints]
steps:
- uses: actions/checkout@v2

- uses: actions/cache@v3
name: Check for ts cache
id: ts-cache
with:
path: |
**/dist/**/*.ts
!**/node_modules
key: ${{ runner.os }}-ts-cache-${{ hashFiles('**/tsconfig.js', '**/package.tsconfig.js', '**/src/', '**/scripts/', '!**/node_modules', '!**/dist') }}

- name: Use Node.js 16
if: ${{ steps.ts-cache.outputs.cache-hit != 'true' }}
uses: actions/setup-node@v3
with:
node-version: '16'
cache: yarn
cache-dependency-path: 'yarn.lock'

- name: Install
if: ${{ steps.ts-cache.outputs.cache-hit != 'true' }}
run: yarn install --frozen-lockfile --prefer-offline

- name: build-ts
if: ${{ steps.ts-cache.outputs.cache-hit != 'true' }}
run: yarn build:ts
run: yarn build

chromatic:
name: Chromatic
runs-on: ubuntu-latest
needs: [install, build]
needs: [build]
steps:
- name: Checkout
uses: actions/checkout@v2
Expand Down Expand Up @@ -205,7 +101,7 @@ jobs:
tests:
name: Run tests
runs-on: ubuntu-latest
needs: [install, build]
needs: [build]
steps:
- uses: actions/checkout@v2

Expand Down Expand Up @@ -235,7 +131,7 @@ jobs:
tests-ssr:
name: Run tests with artificial server rendering
runs-on: ubuntu-latest
needs: [install, build]
needs: [build]
steps:
- uses: actions/checkout@v2

Expand All @@ -262,10 +158,10 @@ jobs:
env:
JEST_JUNIT_OUTPUT: 'reports/junit/js-test-ssr-results.xml'

checkBuilds:
name: Verify builds
validate-builds:
name: Validate builds & dependencies
runs-on: ubuntu-latest
needs: [install, build, build-ts]
needs: [build]
steps:
- uses: actions/checkout@v2

Expand Down Expand Up @@ -296,36 +192,5 @@ jobs:
!**/node_modules
key: ${{ runner.os }}-ts-cache-${{ hashFiles('**/tsconfig.js', '**/package.tsconfig.js', '**/src/', '**/scripts/', '!**/node_modules', '!**/dist') }}

- name: check builds
run: yarn check:builds

sizeDiff:
name: Check file size
runs-on: ubuntu-latest
needs: install
steps:
- uses: actions/checkout@v2

- name: Use Node.js 16
uses: actions/setup-node@v3
with:
node-version: '16'
cache: yarn
cache-dependency-path: 'yarn.lock'

- run: yarn install --frozen-lockfile --prefer-offline

- uses: actions/cache/restore@v3
name: Restore build cache
id: build-cache
with:
path: |
**/dist
!**/node_modules
key: ${{ runner.os }}-build-cache-${{ hashFiles('**/rollup.config.js', '**/babel.config.js', '**/src/', '**/scripts/', '!**/node_modules', '!**/dist') }}

- uses: preactjs/compressed-size-action@v2
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
clean-script: 'clean:builds && clean:modules'
build-script: 'build:packages'
- name: validate
run: yarn validate
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ jobs:
run: yarn

- name: Build packages
run: yarn build:packages
run: yarn build

- name: Build typescript
run: yarn build:ts
run: yarn tsc

- name: Build TSDoc
run: yarn docs:tsdoc
run: yarn build:docs

- name: Establish Chromatic baseline
uses: chromaui/action@v1
Expand Down
36 changes: 36 additions & 0 deletions .github/workflows/sizeDiff.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
name: File Size

on:
pull_request:
types: [opened, synchronize, reopened]

jobs:
sizeDiff:
name: Check file size
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2

- name: Use Node.js 16
uses: actions/setup-node@v3
with:
node-version: '16'
cache: yarn
cache-dependency-path: 'yarn.lock'

- run: yarn install --frozen-lockfile --prefer-offline

- uses: actions/cache/restore@v3
name: Restore build cache
id: build-cache
with:
path: |
**/dist
!**/node_modules
key: ${{ runner.os }}-build-cache-${{ hashFiles('**/rollup.config.js', '**/babel.config.js', '**/src/', '**/scripts/', '!**/node_modules', '!**/dist') }}

- uses: preactjs/compressed-size-action@v2
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
clean-script: 'clean'
build-script: 'build'
20 changes: 0 additions & 20 deletions .github/workflows/test-dispatch.yml

This file was deleted.

3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,5 @@ packages/**/stories.js*
# Storybook/Chromatic logs
build-storybook.log

.turbo
.turbo
scripts/tmp.*.ts
2 changes: 1 addition & 1 deletion .npmpackagejsonlintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{
"patterns": ["./packages/code/package.json"],
"rules": {
"prefer-caret-version-dependencies": "warning"
"prefer-caret-version-dependencies": "off"
}
}
]
Expand Down
2 changes: 1 addition & 1 deletion STYLEGUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export const someConstant = {
optionTwo = 'option 2',
} as const;

export type someConstant = typeof someConstant[keyof typeof someConstant];
export type someConstant = (typeof someConstant)[keyof typeof someConstant];
```

#### Avoid
Expand Down
Loading
Loading