Table cell overflow [LG-3952] #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0ba8d2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +419 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
TheSonOfThomp
changed the title
bruugey
reviewed
Jan 18, 2024
bruugey
reviewed
Jan 18, 2024
bruugey
reviewed
Jan 22, 2024
| @@ -198,7 +199,7 @@ export const LiveExample: StoryFn<StoryTableProps> = args => { | |||
| <Row key={row.id} row={row}> | |||
| {row.getVisibleCells().map(cell => { | |||
| return ( | |||
| <Cell key={cell.id}> | |||
| <Cell key={cell.id} id={cell.id} overflow="truncate"> | |||
There was a problem hiding this comment.
should we add an explicit story to test this?
There was a problem hiding this comment.
Don't think we need a whole new story. I've set up the makeData function to make sure it generates at least one row of long content
bruugey
approved these changes
Jan 23, 2024
TheSonOfThomp
merged commit 3030063
into
LG-3439-cell-max-height-2
8 of 9 checks passed
bruugey
added a commit
that referenced
this pull request
Jan 25, 2024
* change to super high value * change height value * changeset * docs * apply disableAnimations prop down to subcomponents * tests * tests * fix animation jumpiness * remove transition function * rename spec describe * measure content height with ref * apply ref height calculation to cell transition * Update Tooltip.spec.tsx * Table cell overflow [LG-3952] (#2175) * Update makeData.testutils.tsx * Adds `overflow` prop. Styles truncated text * Update InternalCell.tsx * import correct styles * Create wicked-impalas-battle.md * contentClassName prop * fix max-height default --------- Co-authored-by: Adam Thompson <[email protected]> Co-authored-by: Adam Thompson <[email protected]> Co-authored-by: Brooke Scarlett Yalof <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Adds
overflowprop toCellcomponent. By default there is no change. Whenoverflow === 'truncate', the styling of the cell is updated (if necessary) to be aligned to the top, with an ellipsis after 2 lines of text.🎟 Jira ticket:
LG-3952
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changes