LG-3959 Combobox value change #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbobox/src/types/Combobox.types.ts to /Users/adam.thompson/Documents/GitHub/leafygreen-ui/packages/combobox/src/types/ComboboxOptionProps.types.ts
…/combobox/src/types/Combobox.types.ts
…mbobox/src/types/Combobox.types.ts to /Users/adam.thompson/Documents/GitHub/leafygreen-ui/packages/combobox/src/types/ComboboxProps.types.ts
…/combobox/src/types/Combobox.types.ts
…mbobox/src/types/Combobox.types.ts to /Users/adam.thompson/Documents/GitHub/leafygreen-ui/packages/combobox/src/types/ComboboxGroupProps.types.ts
…/combobox/src/types/Combobox.types.ts
…mbobox/src/types/Combobox.types.ts to /Users/adam.thompson/Documents/GitHub/leafygreen-ui/packages/combobox/src/types/ComboboxChipProps.types.ts
…/combobox/src/types/Combobox.types.ts
was in wrong pr
🦋 Changeset detectedLatest commit: 95ff2a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
We considered adding a second callback (i.e.
|
|
Size Change: +94 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
TheSonOfThomp
force-pushed
the
adam/lg-3959-combobox-value-change
branch
from
b12b26f
to
eb524c6
Compare
bruugey
reviewed
Jan 24, 2024
bruugey
reviewed
Jan 24, 2024
|
|
||
| if (select === 'multiple') { | ||
| expect(onChange).toHaveBeenCalledWith( | ||
| expect.arrayContaining(['carrot']), |
There was a problem hiding this comment.
is this correct - an array containing an array with the string 'carrot'?
I'd expect arrayContaining('carrot')
There was a problem hiding this comment.
yeah it's confusing. Its essentially "array containing these elements: [...]"
(There's a case where I call expect.arrayContaining(['apple', 'banana']) )
bruugey
reviewed
Jan 24, 2024
| const multiselectOnChange = onChange as onChangeType<true>; | ||
| const diff: DiffObject = { | ||
| diffType: 'delete', | ||
| value: value ?? selection, |
There was a problem hiding this comment.
should this be newSelection
There was a problem hiding this comment.
No, since in the case that value is null it means we're deleting all elements. So newSelection is []
So the call would be something like:
onChange={(val, diff) => {
console.log(val) // [] (i.e. newSelection)
console.log(diff); // { diffType: 'delete', value: ['apple', 'banana'] }
}} 
shaneeza
reviewed
Jan 25, 2024
bruugey
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: https://jira.mongodb.org/browse/LG-3959
RFC: https://docs.google.com/document/d/1LFAw9sqVyOqPKYkQ2NKDPqQLUBMJDsG-6VhIj-mw2kU/edit?usp=sharing
Combobox
onChangecallback now receives an optional 2nd argument. Use this argument to determine what value was inserted or deleted from a multiselect value.Example:
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changes