LG-3878: Date Picker add current year/month selection to aria-label #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 838b546 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +48 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
shaneeza
changed the title
packages/date-picker/src/DatePicker/DatePickerMenu/DatePickerMenu.spec.tsx
Outdated
Show resolved
Hide resolved
| @@ -123,7 +123,9 @@ export const DatePickerMenuHeader = forwardRef< | |||
| <div className={menuHeaderSelectContainerStyles}> | |||
| <Select | |||
| {...selectElementProps} | |||
| aria-label="Select month" | |||
| aria-label={`Select month - ${ | |||
| monthOptions[month.getUTCMonth()].short | |||
There was a problem hiding this comment.
I think we want .long. As-is this will announce "Select month - Dec selected".
Also, not sure how VO handles dashes like that
There was a problem hiding this comment.
i didn't hear any issues with the dash but I'll double check
There was a problem hiding this comment.
Do you know why it's saying "completion selected" ?
Also, do you know why is says "group, (1 of 2)"? (the year select also says "1 of 2")
There was a problem hiding this comment.
Honestly, I'm not sure; there were a few issues I had while using VO, like not being able to navigate inside the selects. I was gonna investigate a little more and create tickets for them.
TheSonOfThomp
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: LG-3878
Currently, when navigating with VoiceOver, VoiceOver does not announce the current selection for the year and month selects. This happens because we pass a static
aria-labelto theSelectcomponent. My solution is to make thearia-labeldynamic by appending the current selection to thearia-labelstring.✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes