-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more spacing tokens #2220
Conversation
Added spacing tokens up to 64px
🦋 Changeset detectedLatest commit: 8d73f5e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +27 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
@shaneeza @TheSonOfThomp there are more tokens than hex colors hard-coded in the story file - how do we want to handle these colors moving forward? |
Why do we need diff colors? Can we use the same color for all of them? |
You're referring to these colors?. Can we do what charts does and get a palette of N colors |
We could, what do you think @TheSonOfThomp |
Yeah, I don't see a need for them to be different |
So what color? |
Whatever you want... I'd say |
c6990a5
to
8d73f5e
Compare
✍️ Proposed changes
Added spacing tokens up to 64px
🎟 Jira ticket: Name of ticket
✅ Checklist
For bug fixes, new features & breaking changes
yarn changeset
and documented my changesFor new components
🧪 How to test changes