Adds testid guidelines to Styleguide
#2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TheSonOfThomp
requested review from
bruugey and
shaneeza
and removed request for
spark33
TheSonOfThomp
force-pushed
the
adam/lgid
branch
from
4dca626
to
4638ff2
Compare
bruugey
reviewed
Feb 13, 2024
shaneeza
reviewed
Feb 13, 2024
STYLEGUIDE.md
Outdated
| 3. Blocks are separated by dash `-` | ||
| 4. Name hierarchy should somewhat match the directory structure | ||
|
|
||
| e.g. `data-testid="lg-date_picker-calendar_cell"` |
There was a problem hiding this comment.
Should this be lg-date-picker_calendar-cell? date-picker is the block
There was a problem hiding this comment.
No, since "date_picker" is one concept
There was a problem hiding this comment.
Whats the diff between a block and a concept? I know that we are not fully following BEM but from docs it looks like it should be date-picker because that's the block.
There was a problem hiding this comment.
BEM uses dashes to separate words within a block/element, and a double underscore to separate blocks/elements/modifiers.
This proposal is to use a single underscore to separate words, and a dash to separate concepts/elements/blocks
My main gripe with this syntax is that in most text editors a Double click or Option+ArrowKey presses treat underscores as one works and dashes as a separator. So If I want to replace the "calendar_cell" part I can double click it and paste. Or if I want to skip from the end of that string to the previous element I can just press Option + ArrowLeft. All this is backwards with standard BEM
There was a problem hiding this comment.
Can you add this bit to the styleguide? ...use a single underscore to separate words, and a dash to separate concepts/elements/blocks
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
bruugey
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Adds
testidguidelines to StyleguideDiscussed in code review here: https://docs.google.com/document/d/1Vxv2XvPXn5ozAtKSbRQcbC_HgKUBFcn0so6Sm1z28HA/edit#heading=h.lc5w3k6ydn8c