LG-3685, LG-2632: adds backButtonProps and cancelButtonProps to FormFooter component #2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8c15d10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +264 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
stephl3
force-pushed
the
steph/form-footer-buttons
branch
from
c778713
to
cc86ed2
Compare
stephl3
changed the title
stephl3
force-pushed
the
steph/form-footer-buttons
branch
3 times, most recently
from
b1cce85
to
cc257ec
Compare
stephl3
commented
Feb 27, 2024
shaneeza
reviewed
Feb 28, 2024
shaneeza
reviewed
Feb 28, 2024
Comment on lines
61
to
68
| interface BaseButtonProps { | ||
| text?: string; | ||
| onClick?: React.MouseEventHandler<HTMLButtonElement>; | ||
| } | ||
|
|
||
| interface BackButtonProps extends BaseButtonProps { | ||
| leftGlyph?: React.ReactElement | null; | ||
| } |
There was a problem hiding this comment.
Should we allow users to fully customize the buttons? The way I read the ticket, the intent is not only to customize the click handler & left glyph, but allow for further customization.
@bruugey I left a comment in the JIRA ticket, since I'm a bit confused about the AC
There was a problem hiding this comment.
FWIW I think if we're going as far as accepting a prop object, I would prefer a slot API instead. That's the route we took for CanvasHeader, and I'm sure other devs would appreciate the customizability
There was a problem hiding this comment.
I think the diff here is that we don't want consumers to change the button variants.
There was a problem hiding this comment.
yeah from my discussion with design, they only want to introduce button icon customization
so then, customization should be restricted to text + click handler + icon
shaneeza
reviewed
Feb 28, 2024
Comment on lines
61
to
68
| interface BaseButtonProps { | ||
| text?: string; | ||
| onClick?: React.MouseEventHandler<HTMLButtonElement>; | ||
| } | ||
|
|
||
| interface BackButtonProps extends BaseButtonProps { | ||
| leftGlyph?: React.ReactElement | null; | ||
| } |
There was a problem hiding this comment.
FWIW I think if we're going as far as accepting a prop object, I would prefer a slot API instead. That's the route we took for CanvasHeader, and I'm sure other devs would appreciate the customizability
shaneeza
reviewed
Feb 28, 2024
shaneeza
reviewed
Feb 28, 2024
shaneeza
reviewed
Feb 28, 2024
… maintain backwards compatibility
stephl3
force-pushed
the
steph/form-footer-buttons
branch
from
cc257ec
to
557c7e6
Compare
stephl3
force-pushed
the
steph/form-footer-buttons
branch
from
96ac96b
to
f484b83
Compare
stephl3
changed the title
stephl3
changed the title
TheSonOfThomp
approved these changes
Mar 4, 2024
|
|
||
| import { PrimaryButtonProps } from './PrimaryButton'; | ||
|
|
||
| type CustomButtonProps = Pick< |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
cancelButtonPropsandbackButtonPropstoFormFootercomponent for customizing buttons.cancelButtonText,onCancel,backButtonText, andonBackClickprops as deprecated.🎟 Jira ticket: LG-3685 | LG-2632
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changes🧪 How to test changes
Can see the new prop usage in storybook and added unit test blocks