Adds ListSkeleton component [LG-4196]
#2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 801e8e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +611 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
shaneeza
reviewed
Apr 8, 2024
| return spacing[400] + 'px'; | ||
| } | ||
|
|
||
| const offset = 25 * (index % 3); |
There was a problem hiding this comment.
Can you add comments here?
shaneeza
reviewed
Apr 8, 2024
| list-style: none; | ||
|
|
||
| &:not(:first-child), | ||
| &:not(:last-child) { |
There was a problem hiding this comment.
this still targets the first and last element, is that what you want?
There was a problem hiding this comment.
what about
& + & {
margin-block-start: ${spacing[300]}px;
}
There was a problem hiding this comment.
Ah, I don't actually need this anymore since I'm using margin. (was using padding previously)
shaneeza
reviewed
Apr 8, 2024
| export interface ListSkeletonProps | ||
| extends DarkModeProps, | ||
| HTMLElementProps<'ul'> { | ||
| count?: number; |
shaneeza
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: https://jira.mongodb.org/browse/LG-4196
Creates a
ListSkeletoncomponent✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changes