Skeleton Loader - Chromatic tests #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1e88a4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TheSonOfThomp
force-pushed
the
adam/skeleton-tests
branch
from
3e90139
to
ed1f798
Compare
TheSonOfThomp
force-pushed
the
adam/skeleton-tests
branch
from
ed1f798
to
dc3600b
Compare
|
Size Change: +279 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
shaneeza
reviewed
Apr 8, 2024
| <Skeleton size="small" className={lineStyles} /> | ||
| <Skeleton | ||
| enableAnimations={enableAnimations} | ||
| size="small" |
There was a problem hiding this comment.
Can we use Size.Small here?
shaneeza
reviewed
Apr 8, 2024
shaneeza
reviewed
Apr 8, 2024
packages/skeleton-loader/src/ParagraphSkeleton/ParagraphSkeleton.tsx
Outdated
Show resolved
Hide resolved
shaneeza
reviewed
Apr 8, 2024
shaneeza
reviewed
Apr 8, 2024
| }, | ||
| }, | ||
| args: { | ||
| enableAnimations: false, |
There was a problem hiding this comment.
Should this be true by default?
There was a problem hiding this comment.
Not for the snapshot stories. We want to disable animations here so the "shimmer" effect stops, which ensures consistent UI snapshots
shaneeza
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Rewrites Skeleton loader story files to be more reliable in Chromatic tests