Version Packages #2324
Merged
Version Packages #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
stephl3
approved these changes
Apr 26, 2024
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@leafygreen-ui/[email protected]
Major Changes
c406ab8: LG-4133
'small','xsmall', and'large'size variantsA default
errorMessageof'This input needs your attention'will render below combobox when state is invalid.Added a
validstate with success icon andsuccessMessageprop. A defaultsuccessMessageof'Success'will render when state is valid.successMessageprop allows customization.Disabled
Comboboxcomponent no longer renders thedisabledattribute and instead relies onaria-disabledandreadonlyattributes.The last change is made to ensure that disabled components are still focusable to users using keyboard navigation.
For more on
aria-disabledsee the documentation on MDNMigration guide
Functionally, migration should be seamless, however there may be unit/integration/e2e tests that relied on this behavior.
Jest/RTL
Generally, only this repo should need to test that these components have a specific attribute. We recommend updating unit tests to check that some event was or was not called.
However, there are cases where this may still need to be tested. You can replace any
expect(combobox).toBeDisabled()with an explicit check forexpect(combobox).toHaveAttribute('aria-disabled', 'true').Cypress
Similar to unit tests, you should generally test functionality and not implementation details. However, to test this in Cypress replace any
cy.get(combobox).should('be.disabled');checks withcy.get(combobox).invoke('attr', 'aria-disabled').should('eq', 'true');Patch Changes
@leafygreen-ui/[email protected]
Major Changes
c406ab8: LG-4134
'small'and'xsmall'size variants'large'variantAdded default
errorMessageof'This input needs your attention'Added
validstate variant andsuccessMessagepropsuccessMessagewill render a default of'Success'and can be customizedsuccessMessagewill only render whenstate=validPatch Changes
@leafygreen-ui/[email protected]
Major Changes
c406ab8: LG-4135
'small'and'large'size variants'xsmall'varianterrorMessageandsuccessMessagepropserrorMessagewill render a default of'This input needs your attention'and can be customizederrorMessagewill only render whenstateiswarningorerrorsuccessMessagewill render a default of'Success'and can be customizedsuccessMessagewill only render whenstateisvalidaria-describedbyis undefined andstateNotificationsis not an arrayPatch Changes
@leafygreen-ui/[email protected]
Major Changes
c406ab8: LG-4138
'xsmall','small', and'large'size variantsAdded default
errorMessageof'This input needs your attention'Added
validstate variant andsuccessMessagepropsuccessMessagewill render a default of'Success'and can be customizedsuccessMessagewill only render whenstate=validPatch Changes
@leafygreen-ui/[email protected]
Minor Changes
c406ab8: LG-2930
FormFieldFeedbackcomponentDEFAULT_MESSAGESconstantFormFieldandFormFieldInputContainercomponents to use tokens where possibleFormFieldto useFormFieldFeedbackPatch Changes
@leafygreen-ui/[email protected]
Minor Changes
c406ab8: LG-2930
darkModeBackgroundColorsdisabled colorslightModeBorderColorsvariable typo@leafygreen-ui/[email protected]
Minor Changes
c406ab8: LG-2930
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
c406ab8: LG-2930
DatePickertest specsUpdated dependencies [c406ab8]
Updated dependencies [c406ab8]
Updated dependencies [c406ab8]
Updated dependencies [c406ab8]
@leafygreen-ui/[email protected]
Patch Changes