-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(EAI-71) [UI] Rich Links in LG Chat #2328
Conversation
🦋 Changeset detectedLatest commit: 6a0f6ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
38577a5
to
462a450
Compare
Size Change: +607 B (+0.05%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
@shaneeza Ready for another look - thanks! |
@nlarew not sure if you saw my comment here #2328 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
* (EAI-71) [UI] Rich Links in LG Chat * TS error * lint * lint + deps * lint2 * update readme * shaneeza review 1 * chat/rich-links changelog * review 2 * WIP * Remove line wraps * Update & document rich link props * Move @ts-expect-error * remove consoles * text -> children * Remove temp story * Update rich links test with new props * Cast anchorProps as DivProps * sort imports * Add jira link * anchorProps is spread * actually pass the href
✍️ Proposed changes
🎟 Jira ticket: (EAI-71) [UI] Rich Links in LG Chat
Figma: https://www.figma.com/file/L41rvEwQmJJ8VzO4hCPc7Y/LeafyGreen-Chat-Library?type=design&node-id=1%3A492&mode=design&t=rznAQHxznYGhO56X-1
✅ Checklist
For bug fixes, new features & breaking changes
yarn changeset
and documented my changesFor new components
🧪 How to test changes