Refactor FormField #2329
Merged
Refactor FormField #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7cfef1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: -424 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
stephl3
reviewed
Apr 30, 2024
packages/form-field/src/FormFieldInputContainer/FormFieldInputContainer.styles.ts
Outdated
Show resolved
Hide resolved
stephl3
reviewed
Apr 30, 2024
Comment on lines
89
to
93
| &::placeholder { | ||
| color: ${palette.gray.dark1}; | ||
| font-weight: ${fontWeights.regular}; | ||
| color: ${isDarkMode | ||
| ? color.dark.text.primary.default | ||
| : palette.gray.base}; |
There was a problem hiding this comment.
I think the placeholder tokens should be left as-is. They match the tokens used for disabled but shouldn't use the disabled tokens
I don't see placeholder samples in the latest figma file. @alvenw can we add variants to the inputs that provide specs for the placeholder colors?
stephl3
reviewed
Apr 30, 2024
packages/form-field/src/FormFieldInputContainer/FormFieldInputContainer.styles.ts
Outdated
Show resolved
Hide resolved
stephl3
approved these changes
May 1, 2024
Comment on lines
+28
to
+29
| font-size: inherit; | ||
| line-height: inherit; |
There was a problem hiding this comment.
is there still a need to include these inherit values if we set these attributes further down?
| @@ -0,0 +1,200 @@ | |||
| export const countries = [ | |||
There was a problem hiding this comment.
nit: might name this file constants.ts and capitalcase COUNTRIES
There was a problem hiding this comment.
its just for our shared stories - i can, but we could also easily rm and use another example
Comment on lines
+132
to
+136
| [Variant.Placeholder]: { | ||
| [State.Default]: gray.dark1, | ||
| [State.Hover]: gray.dark1, | ||
| [State.Focus]: gray.dark1, | ||
| }, |
There was a problem hiding this comment.
nit: would sort this the same way it is done for lightModeTextColors
stephl3
pushed a commit
that referenced
this pull request
May 22, 2024
* run chromatic * add something back * reset * fix placeholder color * disbaled tokens * fix? * low contrast * light refactor * another fix, another story * last commit pre-separating tokens * card * run fix * validate * add back disabled and placeholder * caught bug * Disable chromatic * placeholder token changeset * confused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: Name of ticket
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes