LeafyGreen UI Avatar [LG-3584] #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6c4fe03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: -1.1 kB (-0.08%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
shaneeza
reviewed
May 21, 2024
shaneeza
reviewed
May 21, 2024
shaneeza
reviewed
May 21, 2024
shaneeza
reviewed
May 21, 2024
shaneeza
reviewed
May 21, 2024
shaneeza
reviewed
May 21, 2024
shaneeza
reviewed
May 21, 2024
shaneeza
reviewed
May 21, 2024
shaneeza
reviewed
May 21, 2024
shaneeza
reviewed
May 21, 2024
shaneeza
reviewed
May 21, 2024
shaneeza
reviewed
May 21, 2024
| } from '../Avatar.constants'; | ||
| import { AvatarProps, AvatarSize, AvatarStyleArgs } from '../Avatar.types'; | ||
|
|
||
| const SINGLE_CHAR_FONT_SCALE = 0.5; // Scalar for `sizeOverride` to font-size |
There was a problem hiding this comment.
I hate to admit this, but I looked up what scalar means, and I don't fully understand the meaning. Can you add a little more to the comment?
There was a problem hiding this comment.
Also, where did these numbers come from?
There was a problem hiding this comment.
They come from visually testing sizes until it looked right 🤷
shaneeza
reviewed
May 21, 2024
shaneeza
reviewed
May 21, 2024
| { | ||
| description: 'Hebrew name (not supported)', | ||
| givenName: 'אדמה', | ||
| surname: 'בר אבא', |
shaneeza
reviewed
May 21, 2024
shaneeza
reviewed
May 21, 2024
shaneeza
reviewed
May 21, 2024
shaneeza
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: Create LGUI Avatar
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components