Extend errorMessage and successMessage types in number input, text area, and text input #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 297eeac The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ea, and text input
stephl3
force-pushed
the
steph/fix-message-types
branch
from
60f7702
to
297eeac
Compare
TheSonOfThomp
approved these changes
May 22, 2024
| @@ -136,12 +136,12 @@ export interface BaseNumberInputProps | |||
| /** | |||
| * The message shown below the input element if the value is invalid. | |||
| */ | |||
| errorMessage?: string; | |||
| errorMessage?: React.ReactNode; | |||
There was a problem hiding this comment.
Do we not have a shared type for these props?
There was a problem hiding this comment.
not currently. do you think it's worth it if it's a simpler type like ReactNode?
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: Name of ticket
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes