LG-4251: remove portal and use descendants pattern in tabs #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
stephl3
force-pushed
the
steph/tabs-no-portal
branch
from
d7a64f8
to
8bd7a41
Compare
|
Size Change: +111 B (+0.01%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
stephl3
force-pushed
the
steph/tabs-no-portal
branch
from
dcd5013
to
2d63657
Compare
stephl3
force-pushed
the
steph/tabs-no-portal
branch
4 times, most recently
from
435225d
to
f24a640
Compare
packages/tabs/src/Tabs/Tabs.tsx
Outdated
Comment on lines
142
to
143
| tabTitleElements[controlledSelected].focus(); | ||
| }, [controlledSelected, isControlled, tabTitleElements]); |
There was a problem hiding this comment.
This will technically fire if/when tabTitleElements or isControlled changes.
I can imagine a case where some external event causes tabs to be added/removed, which would trigger this effect
There was a problem hiding this comment.
If I comment out this useEffect locally, changing selected in Storybook does not update the focus (only the green "selected" indicator)
There was a problem hiding this comment.
@TheSonOfThomp to avoid having the effect run based off external events when tabs are added/removed, I opted to leave out the useEffect. When testing on the Controlled story instance, focus seems to update as intended. Let me know if you think otherwise, and I can add it back in
stephl3
force-pushed
the
steph/tabs-no-portal
branch
from
f24a640
to
d397627
Compare
|
Noticed that setting the controlled state to a disabled index still highlights the tab |
stephl3
force-pushed
the
steph/tabs-no-portal
branch
2 times, most recently
from
70208b7
to
eb5e49c
Compare
Comment on lines
+119
to
+120
| selected={selectedTab} | ||
| setSelected={setSelectedTab} |
There was a problem hiding this comment.
Since we're controlling this value, can we remove it from the SB "controls"
stephl3
force-pushed
the
integration/tabs-refactor
branch
from
598f711
to
9aeec87
Compare
stephl3
force-pushed
the
steph/tabs-no-portal
branch
from
c0b6b76
to
ea8c648
Compare
TheSonOfThomp
approved these changes
May 30, 2024
| @@ -0,0 +1,12 @@ | |||
| export function getActiveAndEnabledIndices( | |||
There was a problem hiding this comment.
imo splitting this into separate getActive... and getEnabled... would be a cleaner DX
If performance is a concern, we can memoize the getEnabled... function so we're not filtering/mapping twice, an leverage it within getActive...
There was a problem hiding this comment.
can address in a follow-up
Comment on lines
+114
to
+116
| (e.key === keyMap.ArrowRight | ||
| ? activeIndex + 1 | ||
| : activeIndex - 1 + numberOfEnabledTabs) % numberOfEnabledTabs |
There was a problem hiding this comment.
this is probably just a prettier thing, but this was hard for me to parse. I read this as only the ArrowLeft case would perform the "mod count" operation
There was a problem hiding this comment.
can address and make more explicit in a follow-up
stephl3
added a commit
that referenced
this pull request
May 31, 2024
* Add @leafygreen-ui/descendants dependency * Use descendants pattern in tabs package * Remove Portal dependency from tabs package * Reorg descendant contexts * Rename tabs event handlers * Rewrite effect * Refactor * Controlled story and consolidate controlled tabs tests * Clean up Controlled story
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Add and export class names (#2335) * LG-3270: fixed tab title height (#2351) * LG-4251: remove portal and use descendants pattern in tabs (#2348) * Add @leafygreen-ui/descendants dependency * Use descendants pattern in tabs package * Remove Portal dependency from tabs package * Reorg descendant contexts * Rename tabs event handlers * Rewrite effect * Refactor * Controlled story and consolidate controlled tabs tests * Clean up Controlled story * LG-2728: migrate from Box to Polymorphic in tabs package (#2359) * LG-2728: migrate from Box to Polymorphic * Address feedback * LG-4147: forceRenderAllTabPanels prop with test util updates (#2357) * Add expect statement to test spec * Refactor TabTitle props and TabPanel * Refactor handleKeyDown and util * Changeset * Fix type * Address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
@leafygreen-ui/descendantsinfra@leafygreen-ui/portaldependencyWill make final changeset after all tabs changes are merged to integration branch
🎟 Jira ticket: LG-4251
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes