LG-4507: fix autocomplete styles in FormFieldInputContainer #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f0e7a51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stephl3
requested review from
shaneeza
and removed request for
TheSonOfThomp
|
Size Change: -106 B (-0.01%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
shaneeza
reviewed
Sep 16, 2024
.changeset/late-houses-work.md
Outdated
| @@ -0,0 +1,8 @@ | |||
| --- | |||
| '@leafygreen-ui/form-field': patch | |||
| '@leafygreen-ui/date-picker': patch | |||
There was a problem hiding this comment.
I don't think that you need to include date-picker, text-area, and text-input since you're not manually bumping the dependency version. The version PR should automatically bump the version and add a changeset.
shaneeza
approved these changes
Sep 16, 2024
stephl3
force-pushed
the
steph/oc-fix-auto-complete-styles
branch
from
099457c
to
f0e7a51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
We received a report of a UI bug in form field components that are using the
FormFieldInputContainer. When the descendant input element is autocompleted,:-webkit-autofillpseudo-selector is applied to the element. Because we useFormFieldInputContainerto handle the styling of the form field, some of the styles are being duplicated in the input element. The issue is especially observable inTextInputbecause the input element doesn't fully stretch the space inFormFieldInputContainer`.We also bump
@leafygreen-ui/text-areaand@leafygreen-ui/date-pickerwhich similarly useFormFieldInputContaineralthough there is less impact because there aren't uses of those components with theautoCompleteprop.🎟 Jira ticket: LG-4507
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changes🧪 How to test changes
TextInputstorybook instanceTextAreastorybook instanceDatePickerstorybook instance