LG-4525: consolidate-usePortal-into-renderMode code mod #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OverlayContext, useOverlayContext, and OverlayProvider * useOverlay to register, remove, and track isTopMostOverlay * Export overlay context related components and hooks and include provider in LG provider * README and changeset * Fix type and lint * Update registerOverlay logic and use more explicit generic type names
* PopoverContext supports additional props and marks isPopoverOpen and setIsPopoverOpen deprecated * Replace PortalContext with newly extended PopoverContext * Changesets * Add todo in select spec and update todos with jira tix
…ClassName prop (#2457) * Refactor popover styles * Remove redundant contentClassName prop * Clean up Popover positioning logic * Changesets * Reorg code * useIsomorphicLayoutEffect instead of useMemo * Update changesets * Revert changes
* Add @floating-ui/react dependency * Clean up Popover stories * Replace position utils and usePopoverPositioning with useFloating * Remove replaced positioning hook and utils * Fix adjustOnMutation and stories * Changeset * Add useMergeRefs hook * Address feedback
* Update Popover default spacing from 10 to 4 * Changeset * Update README and stories
…2474) * Remove justify fit from @leafygreen-ui/popover * Remove justify fit usage in packages using Popover * Changeset
🦋 Changeset detectedLatest commit: 54664af The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stephl3
force-pushed
the
steph/po-code-mods
branch
from
7e740ac
to
c133311
Compare
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
shaneeza
reviewed
Sep 20, 2024
tools/codemods/src/codemods/consolidate-popover-usePortal-renderMode-props/transform.ts
Outdated
Show resolved
Hide resolved
shaneeza
reviewed
Sep 20, 2024
| const isPropValueString = typeof propValue === 'string'; | ||
| const attrValueNode = isPropValueString | ||
| ? j.stringLiteral(propValue) | ||
| : j.jsxExpressionContainer(j.literal(propValue)); |
There was a problem hiding this comment.
It's been a while, so I don't remember; what does jsxExpressionContainer return?
There was a problem hiding this comment.
it wraps the value in curly brackets
shaneeza
reviewed
Sep 20, 2024
| }; | ||
|
|
||
| /** | ||
| * Example transformer function to consolidate props |
There was a problem hiding this comment.
Can you update this line, explaining what this codemod does?
shaneeza
reviewed
Sep 20, 2024
There was a problem hiding this comment.
This looks great! A few comments I have:
- Can you update the README to include this codemod? We should also remove the current codemods in the README because those currently are not consumer-facing.
- Should we also add a section in
Popover's README about this codemod? - You mentioned before about creating codemods for components that consume
Popoversuch asSelect,Tooltip, etc. What's the plan for those components? We could technically add all those components into this codemode. We can create an array of components that need updating and loop through them in the transformer file. - Were you able to test this locally with
yarn lg codemod consolidate-usePortal-into-renderMode <path>?
done!
I have some README changes in PR #2482 that I'd want to build off of. I will revisit this with work in this ticket
great, I updated the code mod to cover those components as well
I tested it locally on the LGUI repo, and it's able to correctly modify most instances. It errors on a few unique cases which I might expect it to but curious what degree of effectiveness we should expect / be aiming for:
|
stephl3
force-pushed
the
steph/po-code-mods
branch
from
6bd427a
to
54664af
Compare
stephl3
commented
Oct 8, 2024
Comment on lines
+39
to
+52
| componentNames = [ | ||
| 'Code', | ||
| 'Combobox', | ||
| 'DatePicker', | ||
| 'InfoSprinkle', | ||
| 'InlineDefinition', | ||
| 'Menu', | ||
| 'NumberInput', | ||
| 'Popover', | ||
| 'SearchInput', | ||
| 'Select', | ||
| 'SplitButton', | ||
| 'Tooltip', | ||
| ], |
There was a problem hiding this comment.
Check these
- Combobox
- DatePicker (DatePickerMenu)
- GuideCue (Beacon)
- Menu
- SplitButton
- SearchInput
- Select
- Code (LanguageSwitcher)
- DatePicker (MM/YY selectors)
- NumberInput (UnitSelect)
- Pagination
- Tooltip
- Code (CopyButton)
- Copyable
- GuideCue (TooltipContent)
- InfoSprinkle
- InlineDefinition
- NumberInput (UnitSelectButton)
- Pipeline
- SideNav
- Stepper
Add default and consolidate for the following:
- Combobox
- Menu
- Select
- SplitButton
- Tooltip
Remove props and always use top layer for the following:
- Code
- DatePicker
- GuideCue
- InfoSprinkle
- InlineDefinition
- NumberInput
- SearchInput
Remove shouldTooltipUsePortal and always use top layer:
- Copyable
Does not need mod:
- Pagination
- Pipeline
- SideNav
- Stepper
stephl3
force-pushed
the
LG-4121-popover-refactor
branch
from
6c8a4cd
to
3cfece1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
consolidate-usePortal-into-renderModecode mod🎟 Jira ticket: LG-4525
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changes