-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Modal component to use dialog element #2579
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: ebdccd7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
return ( | ||
<PopoverProvider> | ||
<LeafyGreenProvider> | ||
<dialog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering if we should deprecate contentClassName in favor of className since there's only one element now?
Size Change: -2.06 kB (-0.15%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
✍️ Proposed changes
🎟 Jira ticket: Name of ticket
✅ Checklist
For bug fixes, new features & breaking changes
yarn changeset
and documented my changesFor new components
🧪 How to test changes