Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-4650: migrate from yarn to pnpm #2612

Merged
merged 49 commits into from
Jan 17, 2025
Merged

LG-4650: migrate from yarn to pnpm #2612

merged 49 commits into from
Jan 17, 2025

Conversation

stephl3
Copy link
Collaborator

@stephl3 stephl3 commented Dec 24, 2024

✍️ Proposed changes

  • migrates from yarn to pnpm

🎟 Jira ticket: LG-4650

✅ Checklist

For bug fixes, new features & breaking changes

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have run yarn changeset and documented my changes

🧪 How to test changes

  • spot check storybook

Copy link

changeset-bot bot commented Dec 24, 2024

🦋 Changeset detected

Latest commit: b7e4af9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 94 packages
Name Type
@leafygreen-ui/leafygreen-provider Patch
@leafygreen-ui/confirmation-modal Patch
@leafygreen-ui/inline-definition Patch
@leafygreen-ui/loading-indicator Patch
@leafygreen-ui/segmented-control Patch
@lg-tools/storybook-decorators Patch
@leafygreen-ui/expandable-card Patch
@leafygreen-ui/marketing-modal Patch
@leafygreen-ui/radio-box-group Patch
@leafygreen-ui/skeleton-loader Patch
@leafygreen-ui/password-input Patch
@lg-chat/fixed-chat-window Patch
@leafygreen-ui/info-sprinkle Patch
@lg-chat/message-feedback Patch
@leafygreen-ui/input-option Patch
@leafygreen-ui/number-input Patch
@leafygreen-ui/ordered-list Patch
@leafygreen-ui/search-input Patch
@leafygreen-ui/split-button Patch
@lg-tools/storybook-addon Patch
@lg-tools/storybook-utils Patch
@lg-chat/chat-disclaimer Patch
@lg-chat/message-prompts Patch
@leafygreen-ui/date-picker Patch
@leafygreen-ui/descendants Patch
@leafygreen-ui/empty-state Patch
@leafygreen-ui/form-footer Patch
@leafygreen-ui/icon-button Patch
@leafygreen-ui/polymorphic Patch
@leafygreen-ui/radio-group Patch
@leafygreen-ui/testing-lib Patch
@lg-tools/test-harnesses Patch
@lg-chat/message-rating Patch
@leafygreen-ui/date-utils Patch
@leafygreen-ui/form-field Patch
@leafygreen-ui/pagination Patch
@leafygreen-ui/text-input Patch
@leafygreen-ui/typography Patch
@leafygreen-ui/guide-cue Patch
@leafygreen-ui/text-area Patch
@lg-chat/message-feed Patch
@leafygreen-ui/checkbox Patch
@leafygreen-ui/combobox Patch
@leafygreen-ui/copyable Patch
@leafygreen-ui/pipeline Patch
@leafygreen-ui/side-nav Patch
@lg-chat/chat-window Patch
@lg-chat/lg-markdown Patch
@leafygreen-ui/callout Patch
@leafygreen-ui/palette Patch
@leafygreen-ui/popover Patch
@leafygreen-ui/stepper Patch
@leafygreen-ui/tooltip Patch
@lg-chat/rich-links Patch
@leafygreen-ui/avatar Patch
@leafygreen-ui/banner Patch
@leafygreen-ui/button Patch
@leafygreen-ui/portal Patch
@leafygreen-ui/ripple Patch
@leafygreen-ui/select Patch
@leafygreen-ui/toggle Patch
@leafygreen-ui/tokens Patch
@lg-chat/input-bar Patch
@lg-chat/title-bar Patch
@leafygreen-ui/badge Patch
@leafygreen-ui/hooks Patch
@leafygreen-ui/modal Patch
@leafygreen-ui/table Patch
@leafygreen-ui/toast Patch
@lg-tools/codemods Patch
@lg-tools/slackbot Patch
@lg-tools/validate Patch
@leafygreen-ui/a11y Patch
@leafygreen-ui/card Patch
@leafygreen-ui/chip Patch
@leafygreen-ui/code Patch
@leafygreen-ui/icon Patch
@leafygreen-ui/logo Patch
@leafygreen-ui/menu Patch
@leafygreen-ui/tabs Patch
@lg-tools/install Patch
@lg-chat/message Patch
@leafygreen-ui/box Patch
@leafygreen-ui/lib Patch
@lg-tools/create Patch
@lg-tools/update Patch
@lg-charts/core Patch
@lg-chat/avatar Patch
@lg-tools/build Patch
@lg-tools/link Patch
@lg-tools/lint Patch
@lg-tools/meta Patch
@lg-tools/test Patch
@lg-tools/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stephl3 stephl3 force-pushed the steph/migrate-pnpm branch 6 times, most recently from 760ab4f to 6831d9d Compare January 6, 2025 20:42
@stephl3 stephl3 force-pushed the steph/migrate-pnpm branch 5 times, most recently from afd01c8 to 1522454 Compare January 7, 2025 23:23
@stephl3 stephl3 closed this Jan 7, 2025
@stephl3 stephl3 reopened this Jan 7, 2025
@stephl3 stephl3 force-pushed the steph/migrate-pnpm branch 6 times, most recently from a80f55b to 6b5d8bc Compare January 10, 2025 00:23
@stephl3 stephl3 changed the title Migrate to PNPM LG-4650: migrate from yarn to pnpm Jan 13, 2025
@stephl3 stephl3 requested a review from TheSonOfThomp January 13, 2025 20:30
@stephl3 stephl3 marked this pull request as ready for review January 13, 2025 20:30
@stephl3 stephl3 requested a review from a team as a code owner January 13, 2025 20:30
Copy link
Collaborator

@TheSonOfThomp TheSonOfThomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few nits, and questions about some workspace-wide installed packages

.github/workflows/clean.yml Outdated Show resolved Hide resolved
.github/workflows/pr.yml Show resolved Hide resolved
.github/workflows/pr.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
tools/test/src/index.ts Show resolved Hide resolved
tools/validate/src/dependencies/fixDependencyIssues.ts Outdated Show resolved Hide resolved
.github/workflows/sizeDiff.yml Outdated Show resolved Hide resolved
chat/input-bar/package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@stephl3 stephl3 force-pushed the steph/migrate-pnpm branch 2 times, most recently from e2798ca to 0a9440b Compare January 14, 2025 15:38
@stephl3 stephl3 requested a review from TheSonOfThomp January 14, 2025 16:35
@TheSonOfThomp
Copy link
Collaborator

Any way we can resolve these warnings?

 WARN  Failed to create bin at /Users/adam.thompson/Documents/GitHub/leafygreen-ui/tools/cli/node_modules/.bin/lg-create. ENOENT: no such file or directory, open '/Users/adam.thompson/Documents/GitHub/leafygreen-ui/tools/create/dist/legacy-create.js'
 WARN  Failed to create bin at /Users/adam.thompson/Documents/GitHub/leafygreen-ui/tools/cli/node_modules/.bin/lg-update. ENOENT: no such file or directory, open '/Users/adam.thompson/Documents/GitHub/leafygreen-ui/tools/update/bin/index.js'
 WARN  Failed to create bin at /Users/adam.thompson/Documents/GitHub/leafygreen-ui/tools/cli/node_modules/.bin/lg-create. ENOENT: no such file or directory, open '/Users/adam.thompson/Documents/GitHub/leafygreen-ui/tools/cli/node_modules/@lg-tools/create/dist/legacy-create.js'
 WARN  Failed to create bin at /Users/adam.thompson/Documents/GitHub/leafygreen-ui/tools/cli/node_modules/.bin/lg-update. ENOENT: no such file or directory, open '/Users/adam.thompson/Documents/GitHub/leafygreen-ui/tools/cli/node_modules/@lg-tools/update/bin/index.js'

@stephl3 stephl3 force-pushed the steph/migrate-pnpm branch from 9012652 to 3395623 Compare January 15, 2025 19:51
@TheSonOfThomp TheSonOfThomp added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 16, 2025
@TheSonOfThomp TheSonOfThomp added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 53c67fb Jan 17, 2025
11 checks passed
@TheSonOfThomp TheSonOfThomp deleted the steph/migrate-pnpm branch January 17, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants