LG-4899: getLgIds #2786
Open
LG-4899: getLgIds #2786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2a3427b The changes in this PR will be included in the next version bump. This PR includes changesets to release 61 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +2.08 kB (+0.14%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
packages/gallery-indicator/src/GalleryIndicator/GalleryIndicator.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| import { Variant } from './MenuItem.types'; | ||
| const lgIds = getLgIds(); |
There was a problem hiding this comment.
This'll be different if a custom lgid is provided. technically I guess it doesn't matter here though
TheSonOfThomp
approved these changes
May 21, 2025
| @@ -45,7 +45,7 @@ const Checkbox = React.forwardRef( | |||
| checked: checkedProp, | |||
| className, | |||
| darkMode: darkModeProp, | |||
| 'data-lgid': dataLgId = DEFAULT_LGID_ROOT, | |||
| 'data-lgid': dataLgId = getLgIds().root, | |||
There was a problem hiding this comment.
I don't think we even need to set a default here at all. The prop itself isn't used directly, so if the prop is not passed in, we just pass in undefined to getLgIds on L66.
I don't see any real issues with this, just that we're calling getLgIds() twice if there's no prop passed in (it's a cheap function, so no real concerns, but removing it would be technically correct
| @@ -26,7 +26,7 @@ describe('CopyButton', () => { | |||
| return render( | |||
| <CodeContextProvider | |||
| // @ts-expect-error - other ids are missing but not needed for test | |||
| lgids={{ | |||
| lgIds={{ | |||
There was a problem hiding this comment.
Is this testing that a copyButton with a non-default id can still be queried?
| export const DEFAULT_LGID_ROOT = 'lg-button'; | ||
|
|
||
| export const getLgIds = (root: `lg-${string}` = DEFAULT_LGID_ROOT) => { | ||
| export const getLgIds = (root: LgIdString = DEFAULT_LGID_ROOT) => { |
There was a problem hiding this comment.
Not necessary here, but it might be worth creating a GetLgIdsFunction function type, and maybe a return type?
type GetLgIdsFunction = (root?: LgIdString) => {
root: LgIdString,
...
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: Name of ticket
✅ Checklist
For bug fixes, new features & breaking changes
pnpm changesetand documented my changesFor new components
🧪 How to test changes