-
Notifications
You must be signed in to change notification settings - Fork 68
LG-5043: Drawer layout #2859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shaneeza
wants to merge
92
commits into
LG-5026-drawer-integration
Choose a base branch
from
LG-5043-drawer-layout
base: LG-5026-drawer-integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
LG-5043: Drawer layout #2859
Changes from all commits
Commits
Show all changes
92 commits
Select commit
Hold shift + click to select a range
2862f67
add toolbar
shaneeza 5ff3380
Updates Readme (#2806)
TheSonOfThomp f84dc25
add keyboard focus management
shaneeza 895b29b
fix focus hijacking
shaneeza 5dd7270
naming
shaneeza 1fb3687
updates types, fixes focus on click
shaneeza 88e42a1
Toolbar focus state
shaneeza 9f917f0
fix error
shaneeza 90e6272
add stories
shaneeza 1691d75
toolbar generated stories
shaneeza e50a8a2
ToolbarIconButton generated stories
shaneeza 9f044d3
update comments
shaneeza 15c4d51
add testids and add an error if trying to use ToolbarIconButton outsi…
shaneeza cadc553
interaction tests
shaneeza 504ad86
WIP test harnesses
shaneeza 17dcb6f
test harnesses
shaneeza beb1710
toolbar specs
shaneeza dcdb066
ToolbarIconButton specs
shaneeza 9a577dd
lint
shaneeza f52491a
Merge branch 'main' of github.com:mongodb/leafygreen-ui into LG-5027-…
shaneeza 22ab95c
pass className to styles
shaneeza ad76c37
README
shaneeza 5c34f5d
add missing deps
shaneeza c2f7fd6
use test utils in interaction tests
shaneeza 3cb2e4e
changesets
shaneeza a3c0159
remove darkMode from context
shaneeza 21bcd41
Use latest version of `useBackdropClick` (#2810)
bruugey 2e301f7
fix ts error
shaneeza ec3122c
some cleanup
shaneeza bd3d34e
add ref test
shaneeza 52aab4a
use correct test
shaneeza 35dd431
remove iconButton changes
shaneeza 7a2dac8
Merge branch 'main' of github.com:mongodb/leafygreen-ui into LG-5027-…
shaneeza cfeceeb
hellllllo
shaneeza 878a4b5
fix build error
shaneeza 485b409
Storybook export `findStories` (#2808)
TheSonOfThomp f6ee112
transition styles
shaneeza 7fb9273
wip, transitiob broken
shaneeza 579c830
Updates `lg install` [LG-5040, LG-5041] (#2807)
TheSonOfThomp 1dbfb70
adds two new icons (#2815)
bruugey 3a96365
constants
shaneeza 34b3b95
update README
shaneeza 303aed6
Version Packages (#2811)
github-actions[bot] 21f9e28
wip, translate grid, still not working
shaneeza cb78abb
build error and export const
shaneeza 8840d27
move handle click to context
shaneeza 12a3ef0
unique test ids for toolbarIconButton
shaneeza 1964fd1
Merge branch 'main' of github.com:mongodb/leafygreen-ui into LG-5027-…
shaneeza f7ba181
move test harnesses to testing dir
shaneeza c378333
aria label check
shaneeza 1f65d21
update README
shaneeza c661c83
toolbar layout, wip
shaneeza 310ed9e
standalone overlay not working
shaneeza d1cf203
add back inner drawer styles
shaneeza 3310079
scrolling and shadows
shaneeza 58729c9
remove some comments and shouldAnimate
shaneeza 08d4450
clean up embeddedDrawerLayout
shaneeza 2bee595
comments
shaneeza eddcf06
overlayDrawerLayout cleanup
shaneeza c9fdc1e
constants for grid areas
shaneeza 7b507b9
shadow transition
shaneeza 60a9f40
rename removeShadowStyles
shaneeza d57ce12
remove some comments
shaneeza d8254e2
remove some styles
shaneeza 4cf70e0
move to DrawerToolbarLayout
shaneeza 944213a
update stories
shaneeza f2fd6dd
controls to exclude
shaneeza 16871fd
update stories
shaneeza a9c9c31
Add more descriptive labels to some toolbar icons
shaneeza ce5fd1a
Merge branch 'LG-5027-toolbar' of github.com:mongodb/leafygreen-ui in…
shaneeza 95aa6dc
clean up
shaneeza 2b8f1e5
tsdocs for LayoutData
shaneeza 47aa4bd
fix grid columns on mobile and remove overflow from story
shaneeza c1cebad
update stories
shaneeza eebeff4
merge conflict
shaneeza 9065bbf
wip, position absolute standalone drawer animtion
shaneeza 2e73458
wip: adjust keyframe timing in drawer animation for smoother transition
shaneeza f1c9961
feat: enhance drawer styles with border adjustments and animation fixes
shaneeza d42ee03
add opacity to inner container, add shouldAnimate check
shaneeza af4527f
added some clarifying comments about styles
shaneeza ed3462a
fix tests and run lint
shaneeza 8186768
refactor: improve transition properties and ensure consistent animati…
shaneeza 3214bb1
refactor: rename type for clarity and remove unused styles file
shaneeza 2abcaf2
update README
shaneeza 0691e42
add temp height to cloudnav story
shaneeza 2d713ed
remove comment and pass args in stories
shaneeza a4dbbbb
update stories so arg does not override displayMode
shaneeza cda8fb3
add comment about story border
shaneeza e304b17
remove height transition
shaneeza 2a67820
sandy feedback, semibold drawer title
shaneeza 7632e09
refactor: update height properties to use 100% for consistency across…
shaneeza 06b9672
remove comment
shaneeza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
export const HEADER_HEIGHT = 48; | ||
export const MOBILE_BREAKPOINT = 390; | ||
export const PANEL_WIDTH = 432; | ||
export const TOOLBAR_WIDTH = 48; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2865