feat(chat): update layout to use flexible height containers #3212
+233
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 55f3bd4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +51 B (0%) Total Size: 1.59 MB
ℹ️ View Unchanged
|
Comment on lines
+7
to
+9
| Note: this should be upgraded with the following packages to avoid UI regressions: | ||
| - `@lg-chat/[email protected]` | ||
| - `@lg-chat/[email protected]` |
There was a problem hiding this comment.
Should we make these peer-dependencies of eachother?
There was a problem hiding this comment.
I worry about making these peer deps because it may lead to further coupling which I'm looking to avoid. I'm thinking about bundling these together as compound components since that's actually how they are used in practice, and I don't think there's a good reason that a consumer would need to import multiple chat packages to build out the same UI
… remove redundant container element
stephl3
force-pushed
the
steph/chat-container-heights
branch
from
f733bba to
ca6bc0d
Compare
This was due to a flake in a |
TheSonOfThomp
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR introduces breaking changes to the chat component layout system to improve flexibility and composability. The main changes include:
Breaking Changes:
@lg-chat/message-feed: Removed the fixed default height of 500px. The component now grows to fill its parent container.@lg-chat/chat-window: Updated the container to take up 100% of the parent's vertical space and added a hidden spacer element to ensure messages flow from the bottom when content is shorter than the container.Supporting Changes:
@lg-chat/fixed-chat-window: Added a fixed 640px height to maintain proper popover sizing (this package will be deprecated soon).@lg-chat/leafygreen-chat-provider: Addedheight: 100%to the wrapper div for proper height propagation.These changes enable better integration with container components like Drawer and provide more flexible layout options. A new
InDrawerLayoutstory demonstrates the improved integration with the Drawer component.@lg-chat/[email protected]@lg-chat/[email protected]@lg-chat/[email protected]🎟️ Jira ticket: No associated ticket
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
InDrawerLayoutstory to verify the chat interface properly fills the drawer panelFixedChatWindowmaintains similar height in the popover